chore: remove all skipLibCheck

web-infra-dev · Dec 5, 2023 · 7b024e5 · 7b024e5
1 parent 752dcbc
commit 7b024e5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/packages/rspack-cli/tsconfig.json b/packages/rspack-cli/tsconfig.json
@@ -2,8 +2,6 @@
   "extends": "../../tsconfig.base.json",
   "include": ["src"],
   "compilerOptions": {
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   },

diff --git a/packages/rspack-dev-server/src/server.ts b/packages/rspack-dev-server/src/server.ts
@@ -24,15 +24,15 @@ export class RspackDevServer extends WebpackDevServer {
 	/**
 	 * resolved after `normalizedOptions`
 	 */
-	// @ts-expect-error
-	options: ResolvedDevServer;
-	// @ts-expect-error
-	staticWatchers: FSWatcher[];
-	// @ts-expect-error
-	sockets: Socket[];
-	// @ts-expect-error
-	server: Server;
-	// @ts-expect-error
+	declare options: ResolvedDevServer;
+
+	declare staticWatchers: FSWatcher[];
+
+	declare sockets: Socket[];
+
+	declare server: Server;
+	// TODO: remove @ts-ignore here
+	/** @ts-ignore */
 	public compiler: Compiler | MultiCompiler;
 	webSocketServer: WebpackDevServer.WebSocketServerImplementation | undefined;
 
@@ -79,6 +79,7 @@ export class RspackDevServer extends WebpackDevServer {
 			},
 			compiler as any
 		);
+		this.staticWatchers;
 	}
 
 	getClientTransport(): string {

diff --git a/packages/rspack-dev-server/tsconfig.json b/packages/rspack-dev-server/tsconfig.json
@@ -4,8 +4,6 @@
     "src"
   ],
   "compilerOptions": {
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   }