Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all skipLibCheck #4910

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore: remove all skipLibCheck #4910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/rspack-cli/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
"extends": "../../tsconfig.base.json",
"include": ["src"],
"compilerOptions": {
// TODO: Remove skipLibCheck when fix upstream type bug
"skipLibCheck": true,
"outDir": "dist",
"rootDir": "src"
},
Expand Down
18 changes: 9 additions & 9 deletions packages/rspack-dev-server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ export class RspackDevServer extends WebpackDevServer {
/**
* resolved after `normalizedOptions`
*/
// @ts-expect-error
options: ResolvedDevServer;
// @ts-expect-error
staticWatchers: FSWatcher[];
// @ts-expect-error
sockets: Socket[];
// @ts-expect-error
server: Server;
// @ts-expect-error
declare options: ResolvedDevServer;

declare staticWatchers: FSWatcher[];

declare sockets: Socket[];

declare server: Server;
// TODO: remove @ts-ignore here
/** @ts-ignore */
public compiler: Compiler | MultiCompiler;
webSocketServer: WebpackDevServer.WebSocketServerImplementation | undefined;

Expand Down
2 changes: 0 additions & 2 deletions packages/rspack-dev-server/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
"src"
],
"compilerOptions": {
// TODO: Remove skipLibCheck when fix upstream type bug
"skipLibCheck": true,
"outDir": "dist",
"rootDir": "src"
}
Expand Down
Loading