support analyze AMD module format

[ahabhgk]

What problem does this feature solve?

• Compatibility of umd/amd output. #2787

What does the proposed API of configuration look like?

https://webpack.js.org/configuration/other-options/#amd

[shaodahong]

I see that it has already been supported.

[ahabhgk]

Nope, I mean analyze dependencies from an AMD module and bundle its dependencies, for now Rspack only support output an AMD format library if I remember correctly

[olhapi]

Great to hear that someone is into that @nilptr That's basically the only thing that's missing and messing the hustle free switch from webpack. We have a bunch of jquery-ui imports that don't work out of the box. Do you know how to fix it before you implement this?

[jackw]

Is this the place to report AMD issues or should I open a new issue?

I'm struggling with Rspack output regarding an AMD build breaking at runtime because of Rspack including the umd wrapper from a dependency:

"../../../../../node_modules/json-logic-js/logic.js": (function (module) {
 /* globals define,module */
 /*
 Using a Universal Module Loader that should be browser, require, and AMD friendly
 http://ricostacruz.com/cheatsheets/umdjs.html
 */
 ;(function(root, factory) {
   if (typeof define === "function" && define.amd) {
     define(factory);
   } else if (true) {
     module.exports = factory();
   } else {}
 }(this, function() {
   "use strict";
   /* globals console:false */
// ... module code

Where as webpack output contains this instead (which doesn't use the global define function):

  /***/ "../../../../../node_modules/json-logic-js/logic.js":
  /*!**********************************************************!*\
    !*** ../../../../../node_modules/json-logic-js/logic.js ***!
    \**********************************************************/
  /***/ (function(module, exports, __webpack_require__) {
  
  var __WEBPACK_AMD_DEFINE_FACTORY__, __WEBPACK_AMD_DEFINE_RESULT__;/* globals define,module */
  /*
  Using a Universal Module Loader that should be browser, require, and AMD friendly
  http://ricostacruz.com/cheatsheets/umdjs.html
  */
  ;(function(root, factory) {
    if (true) {
      !(__WEBPACK_AMD_DEFINE_FACTORY__ = (factory),
      __WEBPACK_AMD_DEFINE_RESULT__ = (typeof __WEBPACK_AMD_DEFINE_FACTORY__ === 'function' ?
      (__WEBPACK_AMD_DEFINE_FACTORY__.call(exports, __webpack_require__, exports, module)) :
      __WEBPACK_AMD_DEFINE_FACTORY__),
      __WEBPACK_AMD_DEFINE_RESULT__ !== undefined && (module.exports = __WEBPACK_AMD_DEFINE_RESULT__));
    } else {}
  }(this, function() {
    "use strict";
    /* globals console:false */

The bundle is built with output.library.type = 'amd' but the environment the bundle is loaded in uses SystemJS and it's AMD extra. As the rspack output uses global define() this breaks as SystemJS creates a System.Register module under the hood which results in the json-logic-js module being empty.