-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: splitChunks.enforce, pass more webpack-tests #4353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSerFeng
requested review from
a team,
LingyuCoder,
jerrykingxyz,
IWANABETHATGUY and
ScriptedAlchemy
October 17, 2023 15:12
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Oct 17, 2023
JSerFeng
changed the title
Fix splitChunks.enforce, pass more webpack-tests
fix: splitChunks.enforce, pass more webpack-tests
Oct 17, 2023
github-actions
bot
added
the
release: bug fix
release: bug related release(mr only)
label
Oct 17, 2023
JSerFeng
force-pushed
the
webpack-tests
branch
from
October 20, 2023 09:12
e02c088
to
c95cecc
Compare
Test Compatibility Diff
Unpassed tests
|
ahabhgk
approved these changes
Oct 20, 2023
IWANABETHATGUY
pushed a commit
that referenced
this pull request
Oct 22, 2023
fix: splitChunks.enforce should enforce minChunks to be 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: bug fix
release: bug related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Require Documentation?