-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable oxc_resolver in webpack tests #4374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boshen
requested review from
a team,
LingyuCoder,
ahabhgk,
IWANABETHATGUY and
ScriptedAlchemy
October 20, 2023 08:06
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Oct 20, 2023
Boshen
force-pushed
the
webpack-test-new-resolver
branch
2 times, most recently
from
October 20, 2023 08:52
97c1de4
to
94e59f0
Compare
Boshen
force-pushed
the
webpack-test-new-resolver
branch
from
October 23, 2023 07:23
94e59f0
to
9adb456
Compare
No webpack compat diff is getting posted due to #4392 |
Test Compatibility Diff
Unpassed tests
|
Can you also enable this in |
Done, although no new test passed :-( |
ahabhgk
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4317
I also enabled some passing resolve tests. I'll look at the failing ones in detail when I get more time.
The cases I checked are the ones listed in #3243 under resolve.