-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: css loading #8534
refactor: css loading #8534
Conversation
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #8534 will not alter performanceComparing Summary
|
325cb04
to
fac9e77
Compare
6cb1b12
to
ef81666
Compare
ef81666
to
65a841d
Compare
Test Compatibility Diff
Unpassed tests4 🔴 Stats chunkGroups: TODO |
Summary
Ref: webpack/webpack#18982
close #8027
Refactor css loading, before we align with webpack that put css modules inside css chunk by encoded css modules info, this can cause problems, it assumes that when javascript start executing, link tags are all loaded, but that was not correct, see webpack/webpack#17611.
This can causing output size a little bit larger, as there are some same css modules, like followings:
We will solve this later
Checklist