[POC] function reg full transform scalar merge #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 12, 2023 11:50
1. FunctionRegistry keeps the old FUNCTION_INFO_MAP only 2. moved Calcite Catalog-based schema.Function registry to its own package; along with a SqlOperator based PinotOperatorTable 3. both CatalogReader and OperatorTable utilizes ground truth function from PinotFunctionRegistry --> will be default once deprecate FunctionRegistry 4. PinotFunctionRegistry provides argument-type based lookup via the same method SqlValidator utilize to lookup routine (and lookup operator overload) 5. clean up multi-stage engine side accordingly
…dynamic operand/return inference
walterddr
changed the title
walterddr
force-pushed
the
poc_function_reg_full
branch
from
5f65e91 to
89c8335
Compare
gortiz
reviewed
Jan 10, 2024
| @@ -41,7 +41,7 @@ | |||
| * - byte[] | |||
| */ | |||
| @Retention(RetentionPolicy.RUNTIME) | |||
| @Target(ElementType.METHOD) | |||
| @Target({ElementType.METHOD, ElementType.TYPE}) | |||
There was a problem hiding this comment.
I would suggest to use AutoService instead of this annotation, but in case we still use it, I would remove the ElementType.METHOD, because we are only going to look for classes annotated with this, right?
There was a problem hiding this comment.
for majority of the methods we can simply support method annotation (most of these are static, single-impl, concrete type)
|
part of the design in this POC is merged into apache#12302 |
walterddr
commented
Feb 15, 2024
Comment on lines
1072
to
+1073
| @ScalarFunction(names = {"dateTrunc", "date_trunc"}) | ||
| public static class dateTruncScalarFunctions { |
There was a problem hiding this comment.
changes that needs to be made to all ScalarFunction with TransformFunctionType associated with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.