forked from apache/pinot
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
create new function registry mechansim
1. FunctionRegistry keeps the old FUNCTION_INFO_MAP only 2. moved Calcite Catalog-based schema.Function registry to its own package; along with a SqlOperator based PinotOperatorTable 3. both CatalogReader and OperatorTable utilizes ground truth function from PinotFunctionRegistry --> will be default once deprecate FunctionRegistry 4. PinotFunctionRegistry provides argument-type based lookup via the same method SqlValidator utilize to lookup routine (and lookup operator overload) 5. clean up multi-stage engine side accordingly
- Loading branch information
Rong Rong
committed
Dec 18, 2023
1 parent
33017d7
commit 5f65e91
Showing
14 changed files
with
620 additions
and
280 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
pinot-common/src/main/java/org/apache/pinot/common/function/registry/PinotFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pinot.common.function.registry; | ||
|
|
||
| import org.apache.calcite.schema.Function; | ||
| import org.apache.calcite.sql.type.SqlOperandTypeChecker; | ||
| import org.apache.calcite.sql.type.SqlReturnTypeInference; | ||
|
|
||
|
|
||
| public interface PinotFunction extends Function { | ||
| SqlOperandTypeChecker getOperandTypeChecker(); | ||
| SqlReturnTypeInference getReturnTypeInference(); | ||
| } |
83 changes: 83 additions & 0 deletions
83
...t-common/src/main/java/org/apache/pinot/common/function/registry/PinotScalarFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pinot.common.function.registry; | ||
|
|
||
| import java.lang.reflect.Method; | ||
| import org.apache.calcite.rel.type.RelDataType; | ||
| import org.apache.calcite.rel.type.RelDataTypeFactory; | ||
| import org.apache.calcite.schema.ScalarFunction; | ||
| import org.apache.calcite.schema.impl.ReflectiveFunctionBase; | ||
| import org.apache.calcite.sql.type.SqlOperandTypeChecker; | ||
| import org.apache.calcite.sql.type.SqlReturnTypeInference; | ||
| import org.apache.pinot.common.function.FunctionInfo; | ||
|
|
||
|
|
||
| /** | ||
| * Pinot specific implementation of the {@link ScalarFunction}. | ||
| * | ||
| * @see "{@link org.apache.calcite.schema.impl.ScalarFunctionImpl}" | ||
| */ | ||
| public class PinotScalarFunction extends ReflectiveFunctionBase implements PinotFunction, ScalarFunction { | ||
| private final FunctionInfo _functionInfo; | ||
| private final String _name; | ||
| private final Method _method; | ||
| private final SqlOperandTypeChecker _sqlOperandTypeChecker; | ||
| private final SqlReturnTypeInference _sqlReturnTypeInference; | ||
|
|
||
| public PinotScalarFunction(String name, Method method, boolean isNullableParameter) { | ||
| this(name, method, isNullableParameter, null, null); | ||
| } | ||
|
|
||
| public PinotScalarFunction(String name, Method method, boolean isNullableParameter, | ||
| SqlOperandTypeChecker sqlOperandTypeChecker, SqlReturnTypeInference sqlReturnTypeInference) { | ||
| super(method); | ||
| _name = name; | ||
| _method = method; | ||
| _functionInfo = new FunctionInfo(method, method.getDeclaringClass(), isNullableParameter); | ||
| _sqlOperandTypeChecker = sqlOperandTypeChecker; | ||
| _sqlReturnTypeInference = sqlReturnTypeInference; | ||
| } | ||
|
|
||
| @Override | ||
| public RelDataType getReturnType(RelDataTypeFactory typeFactory) { | ||
| return typeFactory.createJavaType(method.getReturnType()); | ||
| } | ||
|
|
||
| public String getName() { | ||
| return _name; | ||
| } | ||
|
|
||
| public Method getMethod() { | ||
| return _method; | ||
| } | ||
|
|
||
| public FunctionInfo getFunctionInfo() { | ||
| return _functionInfo; | ||
| } | ||
|
|
||
| @Override | ||
| public SqlOperandTypeChecker getOperandTypeChecker() { | ||
| return _sqlOperandTypeChecker; | ||
| } | ||
|
|
||
| @Override | ||
| public SqlReturnTypeInference getReturnTypeInference() { | ||
| return _sqlReturnTypeInference; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.