[multistage][feature] function registry and lookup method consolidation #12229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 4, 2024 07:55
1. FunctionRegistry keeps the old FUNCTION_INFO_MAP only 2. moved Calcite Catalog-based schema.Function registry to its own package; along with a SqlOperator based PinotOperatorTable 3. both CatalogReader and OperatorTable utilizes ground truth function from PinotFunctionRegistry --> will be default once deprecate FunctionRegistry 4. PinotFunctionRegistry provides argument-type based lookup via the same method SqlValidator utilize to lookup routine (and lookup operator overload) 5. clean up multi-stage engine side accordingly
walterddr
force-pushed
the
pr_function_reg_consolidation
branch
2 times, most recently
from
83d9fdc to
63b1002
Compare
walterddr
changed the title
walterddr
changed the title
- use signature type lookup for v2 engine - deprecate usage of FunctionRegistry - allow nullable return from function lookup b/c some operators doesn't have scalar equivalent at the moment
walterddr
force-pushed
the
pr_function_reg_consolidation
branch
from
63b1002 to
65f6790
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12229 +/- ##
============================================
- Coverage 61.53% 61.39% -0.14%
- Complexity 207 1155 +948
============================================
Files 2416 2421 +5
Lines 131177 131487 +310
Branches 20245 20295 +50
============================================
+ Hits 80717 80724 +7
- Misses 44570 44847 +277
- Partials 5890 5916 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- merge PinotFunctionRegistry with FunctionRegistry - renamed to match calcite.schema and calcite.sql from pinot.common.function package
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Doc
https://docs.google.com/document/d/1VcH8k6vU3dTdb717qJo1bgZAAIkeTso6KwKXkzpbAjk/edit
Reference