Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upload-ctx-provider): execute destroy context callback async to ensure all sync callbacks are run #575

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix(upload-ctx-provider): execute destroy context callback async to ensure all sync callbacks are run #575

merged 1 commit into from
Dec 20, 2023

Conversation

nd0ut
Copy link
Member

@nd0ut nd0ut commented Dec 15, 2023

Description

Checklist

@nd0ut nd0ut requested a review from loookashow December 15, 2023 07:39
@nd0ut nd0ut force-pushed the fix/upload-ctx-provider-destroy-callback branch from 48e35e6 to 372e64f Compare December 19, 2023 08:34
@nd0ut nd0ut force-pushed the fix/upload-ctx-provider-destroy-callback branch from 372e64f to a4bbdd0 Compare December 19, 2023 08:50
@nd0ut nd0ut changed the title fix(upload-ctx-provider): check for the context presence before try to unbind from event emitter fix(upload-ctx-provider): execute destroy context callback async to ensure all sync callbacks are run Dec 19, 2023
@nd0ut nd0ut merged commit cbb9a21 into main Dec 20, 2023
1 check passed
@nd0ut nd0ut deleted the fix/upload-ctx-provider-destroy-callback branch December 20, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loookashow loookashow loookashow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nd0ut @loookashow