fix(upload-ctx-provider): execute destroy context callback async to e…

…nsure all sync callbacks are run (#575)
uploadcare · Dec 20, 2023 · cbb9a21 · cbb9a21
1 parent b6eca31
commit cbb9a21
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/abstract/Block.js b/abstract/Block.js
@@ -196,7 +196,10 @@ export class Block extends BaseComponent {
     Data.deleteCtx(this);
 
     if (blocksRegistry.size === 0) {
-      this.destroyCtxCallback();
+      setTimeout(() => {
+        // Destroy global context after all blocks are destroyed and all callbacks are run
+        this.destroyCtxCallback();
+      }, 0);
     }
   }
 

diff --git a/abstract/UploaderBlock.js b/abstract/UploaderBlock.js
@@ -90,10 +90,6 @@ export class UploaderBlock extends ActivityBlock {
     }
   }
 
-  destroyCallback() {
-    super.destroyCallback();
-  }
-
   destroyCtxCallback() {
     this._unobserveCollectionProperties?.();
     this._unobserveCollection?.();