Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload-ctx-provider): execute destroy context callback async to ensure all sync callbacks are run #575

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix(upload-ctx-provider): execute destroy context callback async to ensure all sync callbacks are run #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion abstract/Block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ export class Block extends BaseComponent {
Data.deleteCtx(this);

if (blocksRegistry.size === 0) {
this.destroyCtxCallback();
setTimeout(() => {
// Destroy global context after all blocks are destroyed and all callbacks are run
this.destroyCtxCallback();
}, 0);
}
}

Expand Down
4 changes: 0 additions & 4 deletions abstract/UploaderBlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ export class UploaderBlock extends ActivityBlock {
}
}

destroyCallback() {
super.destroyCallback();
}

destroyCtxCallback() {
this._unobserveCollectionProperties?.();
this._unobserveCollection?.();
Expand Down
Loading