Remove Float64stamped #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is new mesage should be used by the depth driver instead of Float64Stamped
Replaced with RangeStamped. DVL related cold that previously used Float64Stamped should be transitioned to use RangeStamped instead. Other depth driver related code should be changed to use DepthStamped. The only usage of Float64Stamped that is not DVL or depth or depth driver related is in the start gate mission and should be removed (@RustyBamboo).
kev-the-dev
approved these changes
Apr 11, 2017
|
This built on the CI and passed all unit tests except the ros_alarms test that always fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the msg in mil_msgs called Float64Stamped. I created two new messages to replace it, DepthStamped and RangeStamped since it was only used for depth driver and DVL driver related things. The only other usage was in the start gate mission by @RustyBamboo, where it should be removed.
@ironmig make sure you use these as you remove the dependencies on uf_common in uf-mil-archive/odometry_tools#3 and elsewhere.
There is no order for merging these PRs that will not break our current build, I think we might as well merge this without waiting for the other things to be completed.
Also added a section to the wiki about not using msgs or srvs void of semantic meaning.