-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sanoid spec file from dev repo, modified to not pull in build dependencies. #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we should tweak the changelog? I'm not sure what the version would be since we don't want to get out of sync with the upstream release, but, would be good to reference our deps changes in the changelog.
I was just thinking that after i committed. I have updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specific versioning feedback in the related comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a couple discrepancies in this spec file vs what sanoid docs recommend for CentOS. It gives me the feeling this spec is a bit neglected even in upstream.
I think it would be reasonable to update this spec to match the recommendations I've added as comments. If done, we can add those tweaks to the in-flight changelog entry as well.
Thoughts @johnmmcgee and @KyleGospo ?
I'm happy to help/do the tweaks if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's build this thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I learned something from rpmlint
https://github.com/ublue-os/packages/actions/runs/8364177562/job/22899046010#step:4:52
We can't have a -
hyphen in the version.
So I guess, please change -ucore1
to .ucore1
.
OK! rpmlint fails, because of other spec files, but |
No description provided.