Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sanoid in zfs images #130

Closed
johnmmcgee opened this issue Mar 17, 2024 · 5 comments
Closed

Include sanoid in zfs images #130

johnmmcgee opened this issue Mar 17, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@johnmmcgee
Copy link
Collaborator

sanoid is mentioned in the documentation. It is an excellent tool to automate zfs snapshot management, amongst other things. This should be added as a "Batteries Included" feature.

https://github.com/jimsalterjrs/sanoid

There is already a spec file, as well: https://github.com/jimsalterjrs/sanoid/blob/master/packages/rhel/sanoid.spec

@bsherman
Copy link
Collaborator

I think we agree, we wouldn't add this to the "just fcos + zfs" images, but...

Do you think we should add to all the ucore zfs images? Or not ucore-minimal:zfs? I'm not sure, though, if you want ZFS, tis super userful and your minimal already is not TOO minimal :-)

But I 100% agree without questions for ucore:zfs and ucore-hci:zfs.

@bsherman bsherman added the enhancement New feature or request label Mar 17, 2024
@johnmmcgee
Copy link
Collaborator Author

johnmmcgee commented Mar 17, 2024

I second ucore:zfs and ucore-hci:zfs. This should not be in ucore-minimal:zfs.

@bsherman
Copy link
Collaborator

I second ucore:zfs and ucore-hci:zfs. This should not be in ucore-minimal:zfs.

Fine with me.

I did just check and our current ucore-minimal:zfs DOES include the perl deps required by sanoid, so we'll need to remove them, but i think that's fine, since probably, the RPM will pull them as a dependency wherever we add it.

Adding here for permanent memory. :-)

@johnmmcgee
Copy link
Collaborator Author

ublue-os/packages#16

@bsherman
Copy link
Collaborator

I've merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants