Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ucore copr repo and install sanoid #131

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

johnmmcgee
Copy link
Collaborator

No description provided.

@johnmmcgee
Copy link
Collaborator Author

/tmp/install-ucore.sh: line 6: ZFS_TAG: unbound variable

Copy link
Collaborator

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change request for zfs deps

ucore/install-ucore.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized in doing local build testing of this PR, the sanoid RPM is pulling in a lot of build-time dependencies as runtime dependencies. Example: binutils, gcc, make and much more

We don't want that in our ucore images... so i think we'll have to figure out how to exclude them... there ARE ways... but it will also require inspection of the spec file itself to see what it's doing.

@bsherman
Copy link
Collaborator

inspection of the spec file itself to see what it's doing.
Instead of inspecting the spec file, i just started rpm-ostree uninstalling packages in a container running this image.

I think one main issue is simply that the spec file requires perl which pulls in all the compiler stuff. Fedora CoreOS doesn't install the perl package, rather it installs perl-interpreter which provides perl without the C compiler baggage.

This tells me we will likely need to host our own spec file for sanoid with slimmer deps, and then build THAT spec file in COPR.

Honestly, not too shocking considering sanoid doesn't build their own RPM.

@bsherman
Copy link
Collaborator

We merged ublue-os/packages#16 to cleanup the dependencies pulled in by sanoid.

Now in COPR we had a problem: https://download.copr.fedorainfracloud.org/results/ublue-os/ucore/fedora-39-x86_64/07189025-sanoid/builder-live.log.gz

Relevant bit seems to be:

+ /usr/lib/rpm/rpmuncompress -x /builddir/build/SOURCES/sanoid-2.2.0.ucore1.tar.gz
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd sanoid-2.2.0.ucore1
/var/tmp/rpm-tmp.2DGIv5: line 41: cd: sanoid-2.2.0.ucore1: No such file or directory

So, the change of version isn't messing with the tarball.

Need to determine if we can fix this or just need to ship the stock version.

@johnmmcgee
Copy link
Collaborator Author

My opinion is just stock version since Release will be set to fedora and this is fedora.

@bsherman bsherman changed the title feat: add ucore corp repo and install sanoid feat: add ucore copr repo and install sanoid Mar 24, 2024
@bsherman bsherman merged commit f667c5e into ublue-os:main Mar 24, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants