-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ucore copr repo and install sanoid #131
Conversation
/tmp/install-ucore.sh: line 6: ZFS_TAG: unbound variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change request for zfs deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized in doing local build testing of this PR, the sanoid RPM is pulling in a lot of build-time dependencies as runtime dependencies. Example: binutils, gcc, make and much more
We don't want that in our ucore
images... so i think we'll have to figure out how to exclude them... there ARE ways... but it will also require inspection of the spec file itself to see what it's doing.
I think one main issue is simply that the spec file requires This tells me we will likely need to host our own spec file for Honestly, not too shocking considering |
We merged ublue-os/packages#16 to cleanup the dependencies pulled in by sanoid. Now in COPR we had a problem: https://download.copr.fedorainfracloud.org/results/ublue-os/ucore/fedora-39-x86_64/07189025-sanoid/builder-live.log.gz Relevant bit seems to be:
So, the change of version isn't messing with the tarball. Need to determine if we can fix this or just need to ship the stock version. |
My opinion is just stock version since Release will be set to fedora and this is fedora. |
No description provided.