-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hack-night page #18
Conversation
bb3e3a2
to
5a0c94d
Compare
Re: styling - Honestly I think for now we stick with the landing page as a basis until if/when we have someone really into wanting to do a full design we can all build from. Tweak however you see fit but let's just roll with the logo colors in dark mode. Those cards were literally Astro defaults I think but I don't hate the hover effect or the fonts currently. Thoughts? EDIT: I think it's worth finding a typeface that matches the logo better than whatever rando is there now. |
Oh hey, look what we have here: |
99c4bb4
to
4ed1f33
Compare
I don't hate the Astro defaults, but the components that came out of the box aren't exactly the most re-usable design elements. I'll try to dip my toes in #21 tomorrow to get a baseline for how to style things, initial color palette, typography, etc. If you or @CKCarr can come up with some copy I'll get the layout rearranged to accommodate. I'm thinking I'll move the tabs down just barely above the fold to make room for hero content and rework the title to free up some space, too. |
5a0c94d
to
5287201
Compare
Adds react integrationa, a react Tabs component, and a /hack-night page Co-authored-by: CKCarr <[email protected]>
- ensures `value` is of type `string` - corrects element IDs (previous "[object Object]") - makes tabs accessible/keyboard navigable
Also made some minor updates to style/copy
d3900ae
to
29df066
Compare
* feat(hacknight-page): add initial hack night event page with resources and details * feat(hacknight-page): add date and time to event details * feat: hack-night page Adds react integration, a react Tabs component, and a /hack-night page Co-authored-by: CKCarr <[email protected]> * chore: cleanup tab component * fix: correct Tabs component's `props` interface - ensures `value` is of type `string` - corrects element IDs (previous "[object Object]") - makes tabs accessible/keyboard navigable * fix: correct and clean up Tab component styles * chore: pin dependencies * chore: fix merge error * chore: unify hack-night pages Also made some minor updates to style/copy * feat: flesh out hack-night pages * chore: lock deps, update lockfile --------- Co-authored-by: CKCarr <[email protected]> Co-authored-by: CKCarr <[email protected]>
This PR adds the react integration and a Tabs component build with a headless ui library (Garden Containers).
To do:
closes #15