Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hack-night page #18

Merged
merged 11 commits into from
Feb 27, 2024
Merged

feat: hack-night page #18

merged 11 commits into from
Feb 27, 2024

Conversation

helmturner
Copy link
Member

@helmturner helmturner commented Feb 17, 2024

This PR adds the react integration and a Tabs component build with a headless ui library (Garden Containers).

To do:

  • Add styling
  • Add content/copy
  • Fix broken element IDs causing buggy keyboard nav

closes #15

@helmturner helmturner added bug Something isn't working feature request New feature / enhancement request frontend content / copy design needs layout/design work or spec accessibility needs accessibility review/fix labels Feb 17, 2024
@helmturner helmturner self-assigned this Feb 17, 2024
@helmturner helmturner linked an issue Feb 17, 2024 that may be closed by this pull request
@zenlex
Copy link
Contributor

zenlex commented Feb 24, 2024

Re: styling - Honestly I think for now we stick with the landing page as a basis until if/when we have someone really into wanting to do a full design we can all build from. Tweak however you see fit but let's just roll with the logo colors in dark mode. Those cards were literally Astro defaults I think but I don't hate the hover effect or the fonts currently. Thoughts?

EDIT: I think it's worth finding a typeface that matches the logo better than whatever rando is there now.

@zenlex
Copy link
Contributor

zenlex commented Feb 24, 2024

@zenlex zenlex force-pushed the dev branch 6 times, most recently from 99c4bb4 to 4ed1f33 Compare February 24, 2024 22:17
@helmturner
Copy link
Member Author

I don't hate the Astro defaults, but the components that came out of the box aren't exactly the most re-usable design elements. I'll try to dip my toes in #21 tomorrow to get a baseline for how to style things, initial color palette, typography, etc.

If you or @CKCarr can come up with some copy I'll get the layout rearranged to accommodate. I'm thinking I'll move the tabs down just barely above the fold to make room for hero content and rework the title to free up some space, too.

@helmturner helmturner marked this pull request as ready for review February 27, 2024 21:19
CKCarr and others added 10 commits February 27, 2024 15:20
@helmturner helmturner merged commit cd4a162 into dev Feb 27, 2024
1 check failed
@helmturner helmturner deleted the feat/hack-night-page branch February 27, 2024 21:29
@helmturner helmturner mentioned this pull request Feb 27, 2024
@helmturner helmturner linked an issue Feb 27, 2024 that may be closed by this pull request
3 tasks
zenlex pushed a commit that referenced this pull request Apr 27, 2024
* feat(hacknight-page): add initial hack night event page with resources and details

* feat(hacknight-page): add date and time to event details

* feat: hack-night page

Adds react integration, a react Tabs component, and a /hack-night page

Co-authored-by: CKCarr <[email protected]>

* chore: cleanup tab component

* fix: correct Tabs component's `props` interface

- ensures `value` is of type `string`
- corrects element IDs (previous "[object Object]")
- makes tabs accessible/keyboard navigable

* fix: correct and clean up Tab component styles

* chore: pin dependencies

* chore: fix merge error

* chore: unify hack-night pages

Also made some minor updates to style/copy

* feat: flesh out hack-night pages

* chore: lock deps, update lockfile

---------

Co-authored-by: CKCarr <[email protected]>
Co-authored-by: CKCarr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility needs accessibility review/fix bug Something isn't working content / copy design needs layout/design work or spec feature request New feature / enhancement request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hack-night Page Copy Build Hack Night Page
3 participants