-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use replicaCount for workflows backend #126
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -301,29 +301,35 @@ workflows: | |
# explicitly set other fields as needed | ||
|
||
# enabled: true | ||
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster | ||
# Scaling this number will increase the number of workflow workers, e.g. a replicaCount of 4 | ||
# will launch 9 pods -- 1 workflow backend, 4 workflow workers, and 4 for temporal cluster | ||
|
||
# ADVANCED: The temporal cluster can be scaled separately in the subchart (charts/retool-temporal-services-helm/values.yaml) | ||
# If your needs require scaling temporal, reach out to us for guidance -- it is likely the bottleneck is DB or worker replicaCount | ||
replicaCount: 1 | ||
worker: | ||
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster | ||
# Scaling this number will increase the number of workflow workers, e.g. a replicaCount of 4 | ||
# will launch 9 pods -- 1 workflow backend, 4 workflow workers, and 4 for temporal cluster | ||
replicaCount: 1 | ||
|
||
backend: | ||
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster | ||
# Scaling this number will increase the number of workflow backends, e.g. a replicaCount of 4 | ||
# will launch 9 pods -- 4 workflow backend, 1 workflow workers, and 4 for temporal cluster | ||
replicaCount: 1 | ||
|
||
# Timeout for queries, in ms. This will set the timeout for workflows-related pods only | ||
# If this value is not set but config.dbConnectorTimeout is, we will set workflows pod timeouts | ||
# to .Values.config.dbConnectorTimeout | ||
# dbConnectorTimeout: 120000 | ||
|
||
# Annotations for workflows worker pods | ||
# Annotations for workflows worker and workflow backend pods | ||
annotations: {} | ||
|
||
# Labels for workflows worker pods | ||
# Labels for workflows worker and workflow backend pods | ||
labels: {} | ||
|
||
# IMPORTANT: Incompatible with retool-temporal-services-helm subchart | ||
# This allows configuring a Retool Workflows deployment that uses your own Temporal cluster | ||
# instead of deploying a new one. Set enabled to true and add the config variables. | ||
# NOTE: Temporal Frontend with required TLS or mTLS not currently supported | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we support this now |
||
temporal: | ||
# set enabled to true if using a pre-existing temporal cluster | ||
enabled: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/a/68807258