Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use replicaCount for workflows backend #126

Merged
merged 2 commits into from
Oct 18, 2023
Merged

use replicaCount for workflows backend #126

merged 2 commits into from
Oct 18, 2023

Conversation

avimoondra
Copy link
Contributor

@avimoondra avimoondra commented Oct 18, 2023 •
edited
Loading

Using old values in new values.yaml:

helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set workflows.worker.replicaCount=null --set workflows.replicaCount=31 --set workflows.backend.replicaCount=null --debug | grep replicas
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  replicas: 2
  replicas: 1
  replicas: 1
  replicas: 31
  replicas: 1

Using new defaults in new values.yaml:

 helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --debug | grep replicas
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  replicas: 2
  replicas: 1
  replicas: 1
  replicas: 1
  replicas: 1

Using new values in new values.yaml:

helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set workflows.worker.replicaCount=31 --set workflows.backend.replicaCount=32 --debug | grep replicas
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  replicas: 2
  replicas: 1
  replicas: 32
  replicas: 31
  replicas: 1

All unset in new values.yaml:

helm template -f ~/retool-helm/charts/retool/values.yaml foo ~/retool-helm/charts/retool --set config.encryptionKey="foo" --set image.tag="5.6.10" --set workflows.worker.replicaCount=null --set workflows.replicaCount=null --set workflows.backend.replicaCount=null --debug | grep replicas
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /Users/avimoondra/retool-helm/charts/retool

  replicas: 2
  replicas: 1
  replicas: 1
  replicas: 1
  replicas: 1

@avimoondra avimoondra force-pushed the avimoondra/update-replica-count-workflows branch from cb0ebd6 to 21d355f Compare October 18, 2023 19:29
@avimoondra avimoondra force-pushed the avimoondra/update-replica-count-workflows branch from 21d355f to e0f67f1 Compare October 18, 2023 19:30
@avimoondra avimoondra marked this pull request as ready for review October 18, 2023 19:31
@avimoondra avimoondra requested a review from jjlgao October 18, 2023 19:31
avimoondra
avimoondra commented Oct 18, 2023
View reviewed changes
charts/retool/templates/deployment_workflows.yaml
@@ -11,7 +11,7 @@ metadata:
{{ toYaml .Values.deployment.annotations | indent 4 }}
{{- end }}
spec:
replicas: 1
replicas: {{ (.Values.workflows.backend).replicaCount | default 1 }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/a/68807258

avimoondra
avimoondra commented Oct 18, 2023
View reviewed changes
charts/retool/values.yaml
labels: {}

# IMPORTANT: Incompatible with retool-temporal-services-helm subchart
# This allows configuring a Retool Workflows deployment that uses your own Temporal cluster
# instead of deploying a new one. Set enabled to true and add the config variables.
# NOTE: Temporal Frontend with required TLS or mTLS not currently supported
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support this now

@avimoondra avimoondra merged commit 45f5b8e into main Oct 18, 2023
12 checks passed
@avimoondra avimoondra deleted the avimoondra/update-replica-count-workflows branch October 18, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjlgao jjlgao jjlgao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avimoondra @jjlgao