Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use replicaCount for workflows backend #126

Merged
merged 2 commits into from
Oct 18, 2023
Merged

use replicaCount for workflows backend #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0f67f1
use replicaCount for workflows backend
Oct 18, 2023
0349886
bump version
Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.0.5
version: 6.0.6
maintainers:
- name: Retool Engineering
email: [email protected]
Expand Down
2 changes: 1 addition & 1 deletion charts/retool/templates/deployment_workflows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
{{ toYaml .Values.deployment.annotations | indent 4 }}
{{- end }}
spec:
replicas: 1
replicas: {{ (.Values.workflows.backend).replicaCount | default 1 }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/a/68807258

selector:
matchLabels:
retoolService: {{ template "retool.fullname" . }}-workflow-backend
Expand Down
2 changes: 1 addition & 1 deletion charts/retool/templates/deployment_workflows_worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
{{ toYaml .Values.deployment.annotations | indent 4 }}
{{- end }}
spec:
replicas: {{ .Values.workflows.replicaCount }}
replicas: {{ (.Values.workflows.worker).replicaCount | default (.Values.workflows.replicaCount | default 1) }}
selector:
matchLabels:
retoolService: {{ template "retool.fullname" . }}-workflow-worker
Expand Down
20 changes: 13 additions & 7 deletions charts/retool/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,29 +301,35 @@ workflows:
# explicitly set other fields as needed

# enabled: true
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster
# Scaling this number will increase the number of workflow workers, e.g. a replicaCount of 4
# will launch 9 pods -- 1 workflow backend, 4 workflow workers, and 4 for temporal cluster

# ADVANCED: The temporal cluster can be scaled separately in the subchart (charts/retool-temporal-services-helm/values.yaml)
# If your needs require scaling temporal, reach out to us for guidance -- it is likely the bottleneck is DB or worker replicaCount
replicaCount: 1
worker:
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster
# Scaling this number will increase the number of workflow workers, e.g. a replicaCount of 4
# will launch 9 pods -- 1 workflow backend, 4 workflow workers, and 4 for temporal cluster
replicaCount: 1

backend:
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster
# Scaling this number will increase the number of workflow backends, e.g. a replicaCount of 4
# will launch 9 pods -- 4 workflow backend, 1 workflow workers, and 4 for temporal cluster
replicaCount: 1

# Timeout for queries, in ms. This will set the timeout for workflows-related pods only
# If this value is not set but config.dbConnectorTimeout is, we will set workflows pod timeouts
# to .Values.config.dbConnectorTimeout
# dbConnectorTimeout: 120000

# Annotations for workflows worker pods
# Annotations for workflows worker and workflow backend pods
annotations: {}

# Labels for workflows worker pods
# Labels for workflows worker and workflow backend pods
labels: {}

# IMPORTANT: Incompatible with retool-temporal-services-helm subchart
# This allows configuring a Retool Workflows deployment that uses your own Temporal cluster
# instead of deploying a new one. Set enabled to true and add the config variables.
# NOTE: Temporal Frontend with required TLS or mTLS not currently supported
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support this now

temporal:
# set enabled to true if using a pre-existing temporal cluster
enabled: false
Expand Down
20 changes: 13 additions & 7 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,29 +301,35 @@ workflows:
# explicitly set other fields as needed

# enabled: true
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster
# Scaling this number will increase the number of workflow workers, e.g. a replicaCount of 4
# will launch 9 pods -- 1 workflow backend, 4 workflow workers, and 4 for temporal cluster

# ADVANCED: The temporal cluster can be scaled separately in the subchart (charts/retool-temporal-services-helm/values.yaml)
# If your needs require scaling temporal, reach out to us for guidance -- it is likely the bottleneck is DB or worker replicaCount
replicaCount: 1
worker:
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster
# Scaling this number will increase the number of workflow workers, e.g. a replicaCount of 4
# will launch 9 pods -- 1 workflow backend, 4 workflow workers, and 4 for temporal cluster
replicaCount: 1

backend:
# A replicaCount of 1 will launch 6 pods -- 1 workflow backend, 1 workflow worker, and 4 pods that make up the executor temporal cluster
# Scaling this number will increase the number of workflow backends, e.g. a replicaCount of 4
# will launch 9 pods -- 4 workflow backend, 1 workflow workers, and 4 for temporal cluster
replicaCount: 1

# Timeout for queries, in ms. This will set the timeout for workflows-related pods only
# If this value is not set but config.dbConnectorTimeout is, we will set workflows pod timeouts
# to .Values.config.dbConnectorTimeout
# dbConnectorTimeout: 120000

# Annotations for workflows worker pods
# Annotations for workflows worker and workflow backend pods
annotations: {}

# Labels for workflows worker pods
# Labels for workflows worker and workflow backend pods
labels: {}

# IMPORTANT: Incompatible with retool-temporal-services-helm subchart
# This allows configuring a Retool Workflows deployment that uses your own Temporal cluster
# instead of deploying a new one. Set enabled to true and add the config variables.
# NOTE: Temporal Frontend with required TLS or mTLS not currently supported
temporal:
# set enabled to true if using a pre-existing temporal cluster
enabled: false
Expand Down
Loading