Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TransformVariables. #89

Merged
merged 12 commits into from
Aug 30, 2022
Merged

Remove TransformVariables. #89

merged 12 commits into from
Aug 30, 2022

Conversation

tpapp
Copy link
Owner

@tpapp tpapp commented Aug 25, 2022

Motivated by discussion in TuringLang/Turing.jl#1877, the TransformVariables-related code will be moved to https://github.com/tpapp/TransformedLogDensities.jl. This makes this package lighter, getting closer to the goal of an interface definition package after AD code is removed.

TODO:

  1. update readme once the abovementioned package registers
  2. deprecations
  3. bump version, release, describe migration for users, update docs
  4. excise relevant code from TransformVariables -> will be done in relevant repo
  5. updated examples for DynamicHMC -> will be done in relevant repo

@tpapp tpapp requested a review from devmotion August 25, 2022 09:18
Copy link
Collaborator

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the simpler and better approach probably.

src/LogDensityProblems.jl Outdated Show resolved Hide resolved
src/utilities.jl Outdated Show resolved Hide resolved
src/LogDensityProblems.jl Show resolved Hide resolved
src/utilities.jl Outdated Show resolved Hide resolved
@tpapp
Copy link
Owner Author

tpapp commented Aug 29, 2022

@devmotion, what would you suggest for deprecation? Eg

  1. @deprecate stuff moved to another package in a patch version, then remove in a minor version? or

  2. just announce the change without @deprecate?

@devmotion
Copy link
Collaborator

I think deprecating (probably with Base.@deprecate_moved?) has the advantage that there is a clearly communicated, officially recommended way of how to upgrade to TransformedLogDensities. So downstream packages that run tests will see the deprecation warnings and how fix them, whereas otherwise they have to dig through PRs and/or release notes. So I guess basically I share Invenia's view on deprecations in Julia: https://invenia.github.io/blog/2022/06/17/deprecating-in-julia/

tpapp added a commit that referenced this pull request Aug 29, 2022
@tpapp tpapp merged commit 428ea4c into master Aug 30, 2022
@tpapp tpapp deleted the tp/remove-transformvariables branch August 30, 2022 09:48
@tpapp tpapp mentioned this pull request Sep 5, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants