Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major API simplification #45

Closed
6 of 7 tasks
tpapp opened this issue Jul 24, 2019 · 1 comment
Closed
6 of 7 tasks

major API simplification #45

tpapp opened this issue Jul 24, 2019 · 1 comment

Comments

@tpapp
Copy link
Owner

tpapp commented Jul 24, 2019 •
edited
Loading

  • logdensity now has 4 versions. two would do (value, value + gradient), and the checks are kind of superfluous and don't work well with AD code. replace with logdensity and logdensity_and_gradient
  • provide validity checks for logdensity (-Inf or finite) as simple functions
  • get rid of wrapper types, unnecessary complication
  • get rid of exceptions like LogDensityRejectErrors, they interfere with AD
  • make tests more organized and modular
  • address functionality involving transformations should be migrated to TransformVariables.jl #33
  • tag new, breaking version, with PSA
@tpapp tpapp mentioned this issue Jul 24, 2019
Closed
tpapp added a commit that referenced this issue Jul 25, 2019
@tpapp
Major API reorganization.
c538c21 
Addresses most of #45.

1. Remove validating wrapper types, simply return tuples.

2. Split `logdensity` into two methods, `logdensity` and `logdensity_and_gradient`.

3. Simplify code.

4. Introduce capabilities traits.

5. Fix #33 by making a distinct `dimension`.

6. Organize code into a single file, mostly.

7. Simplify tests greatly.
@tpapp tpapp mentioned this issue Jul 25, 2019
Merged
tpapp added a commit that referenced this issue Jul 26, 2019
@tpapp
Major API reorganization. (#46)
7803f03 
* Major API reorganization.

Addresses most of #45.

1. Remove validating wrapper types, simply return tuples.

2. Split `logdensity` into two methods, `logdensity` and `logdensity_and_gradient`.

3. Simplify code.

4. Introduce capabilities traits.

5. Fix #33 by making a distinct `dimension`.

6. Organize code into a single file, mostly.

7. Simplify tests greatly.

* improve coverage

* rewrite docs

* changelog for new release
@tpapp
Copy link
Owner Author

tpapp commented Sep 5, 2022

This is mostly done now (#46, #89, #66, #54), validity checks seem to be OK on the caller side, so closing.

@tpapp tpapp closed this as completed Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpapp