deprecate TransformedLogDensity #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for #89.
devmotion
reviewed
Aug 29, 2022
| @@ -159,6 +159,8 @@ struct TransformedLogDensity{T <: TransformVariables.AbstractTransform, L} | |||
| log_density_function::L | |||
| end | |||
|
|
|||
| Base.@deprecate_moved TransformedLogDensity "TransformedLogDensities.TransformedLogDensity" | |||
There was a problem hiding this comment.
I think one should just state the package name here:
Suggested change
| Base.@deprecate_moved TransformedLogDensity "TransformedLogDensities.TransformedLogDensity" | |
| Base.@deprecate_moved TransformedLogDensity "TransformedLogDensities" |
If I understand correctly, one should also remove all occurrences of TransformedLogDensity (and probably all traits for it) since otherwise the deprecation doesn't show up but is "overridden" by the type definition. Users will then see a deprecation warning that points them towards installing and loading TransformedLogDensities.
The macro also exports TransformedLogDensity automatically, so it could be removed from the exports. Similarly, I think the dependency on TransformVariables could be removed.
There was a problem hiding this comment.
Good point, doing that in #89 then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #89.