Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check email before checking name #13

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

zbarahal-do
Copy link
Contributor

As discussed with @timoreimann we found a case where due checking email/name at the same time, we got the wrong person. The case was as such

If there's a list of users with the format name, email

Right Name, [email protected]
Right Name, [email protected]

where both users have the same name but the second user in the list is the one we actually want (by email), the current logic will select the wrong user due to the name match.

We agreed that checking email first and then falling back to name if we can't find a match will fix this behavior while preserving name based search for those who use it.

Copy link
Owner

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@timoreimann timoreimann merged commit ad424a6 into timoreimann:master Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants