Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @timoreimann we found a case where due checking email/name at the same time, we got the wrong person. The case was as such
If there's a list of users with the format name, email
Right Name, [email protected]
Right Name, [email protected]
where both users have the same name but the second user in the list is the one we actually want (by email), the current logic will select the wrong user due to the name match.
We agreed that checking email first and then falling back to name if we can't find a match will fix this behavior while preserving name based search for those who use it.