Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check email before checking name #13

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Check email before checking name #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52593c1
Check email before checking name
zbarahal-do Jan 9, 2024
932c9e5
Apply gofmt and format comments
timoreimann Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions slack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,16 @@ import (
type slackUsers []slackUser

func (users slackUsers) findByPDUser(pdUser pagerduty.User) *slackUser {
// check email match first since it's a distinctive identifier
for _, slackUser := range users {
if slackUser.email == pdUser.Email ||
slackUser.realName == strings.ToLower(pdUser.Name) ||
if slackUser.email == pdUser.Email {
return &slackUser
}
}

// if we couldn't find an email match, use name. this is the second choice as name is not unique in an organization
for _, slackUser := range users {
if slackUser.realName == strings.ToLower(pdUser.Name) ||
slackUser.name == strings.ToLower(pdUser.Name) {
return &slackUser
}
Expand Down
Loading