Check email before checking name (#13)

* Check email before checking name --------- Co-authored-by: Timo Reimann <[email protected]>
timoreimann · Jan 19, 2024 · ad424a6 · ad424a6
1 parent 40583e9
commit ad424a6
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/slack.go b/slack.go
@@ -19,9 +19,16 @@ import (
 type slackUsers []slackUser
 
 func (users slackUsers) findByPDUser(pdUser pagerduty.User) *slackUser {
+	// check email match first since it's a distinctive identifier
 	for _, slackUser := range users {
-		if slackUser.email == pdUser.Email ||
-			slackUser.realName == strings.ToLower(pdUser.Name) ||
+		if slackUser.email == pdUser.Email {
+			return &slackUser
+		}
+	}
+
+	// if we couldn't find an email match, use name. this is the second choice as name is not unique in an organization
+	for _, slackUser := range users {
+		if slackUser.realName == strings.ToLower(pdUser.Name) ||
 			slackUser.name == strings.ToLower(pdUser.Name) {
 			return &slackUser
 		}