Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJD-1057 (2/5): Remove non-API member functions: EntityManager’s TrafficLight related member functions (tests) #1444

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from

Commits on Jul 29, 2024

  1. Revert "Remove traffic lights tests"

    This reverts commit 433019c.
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0dbf4ec View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'RJD-1057-remove-traffic-lights-from-entity-manager' int…

    …o RJD-1057-traffic-lights-tests
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    dd47e53 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge remote-tracking branch 'tier4/RJD-1057-remove-traffic-lights-fr…

    …om-entity-manager' into RJD-1057-traffic-lights-tests
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    43bdeca View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'RJD-1057-remove-traffic-lights-from-entity-manager' int…

    …o RJD-1057-traffic-lights-tests
    dmoszynski authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c1a4a6f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'RJD-1057-remove-traffic-lights-from-entity-manager' int…

    …o RJD-1057-traffic-lights-tests
    dmoszynski authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    215a588 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/RJD-1057-remove-traffic-lights-f…

    …rom-entity-manager' into RJD-1057-traffic-lights-tests
    dmoszynski committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5e841b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    90c693f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Merge remote-tracking branch 'tier4/RJD-1057-remove-traffic-lights-fr…

    …om-entity-manager' into RJD-1057-traffic-lights-tests
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    21c7575 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    f1ec160 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Merge remote-tracking branch 'tier4/master' into RJD-1057-traffic-lig…

    …hts-tests
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    443ce6b View commit details
    Browse the repository at this point in the history
  2. Update TrafficLightPublisher and TrafficLightPublisherBase to comply …

    …with new standard
    
    Move message transformation to TrafficLightPublisherBase static member functions
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4e180f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c6767db View commit details
    Browse the repository at this point in the history
  4. Add missing tests for traffic lights type conversions

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0719815 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    c46cdfb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed975fa View commit details
    Browse the repository at this point in the history
  3. Move traffic light test fixtures to header file

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    72dbd6c View commit details
    Browse the repository at this point in the history
  4. Add include guards to traffic lights test fixtures

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    48cf7d8 View commit details
    Browse the repository at this point in the history
  5. Move V2I tests to new file

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7dff5c2 View commit details
    Browse the repository at this point in the history
  6. Rename common traffic lights tests file

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1e912f9 View commit details
    Browse the repository at this point in the history
  7. Implement missing traffic lights tests and move "new architecture" te…

    …sts to new file
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6901cbb View commit details
    Browse the repository at this point in the history
  8. Merge remote-tracking branch 'tier4/RJD-1057-traffic-lights-tests' in…

    …to RJD-1057-traffic-lights-tests
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f6541dc View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    8d4d76b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    677043d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    083e657 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Apply patch created by Yoshimoto-san

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5750b00 View commit details
    Browse the repository at this point in the history
  2. Improve traffic lights tests comments

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f0202dd View commit details
    Browse the repository at this point in the history
  3. Improve traffic lights tests publishing timing

    Change 'random' numbers to round ones like one second or half a second
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4e45a56 View commit details
    Browse the repository at this point in the history
  4. Improve traffic lights tests epsilons and threshold situation

    Add clear thresholds for tests with explanations and use these thresholds instead of hardcoded values
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7e5c9c8 View commit details
    Browse the repository at this point in the history
  5. Use compile-time check instead of run-time check

    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f5e9b70 View commit details
    Browse the repository at this point in the history
  6. Use new architecture in traffic lights tests: "awf/universe/20230906"…

    … instead of "awf/universe"
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e6bf741 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    0eac745 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    085cb62 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18f1186 View commit details
    Browse the repository at this point in the history
  4. Improve traffic lights tests subscribers

    Make the variables const and add scope for subscribers so they stop listening (only in tests with more than one subscriber + remove .reset() as scopes take care of that
    
    Signed-off-by: Mateusz Palczuk <[email protected]>
    TauTheLepton committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    44bab9f View commit details
    Browse the repository at this point in the history