RJD-1057 (2/5): Remove non-API member functions: EntityManager’s TrafficLight related member functions (tests) #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 433019c. Signed-off-by: Mateusz Palczuk <[email protected]>
…o RJD-1057-traffic-lights-tests Signed-off-by: Mateusz Palczuk <[email protected]>
…om-entity-manager' into RJD-1057-traffic-lights-tests Signed-off-by: Mateusz Palczuk <[email protected]>
…o RJD-1057-traffic-lights-tests
…o RJD-1057-traffic-lights-tests
…rom-entity-manager' into RJD-1057-traffic-lights-tests
…om-entity-manager' into RJD-1057-traffic-lights-tests Signed-off-by: Mateusz Palczuk <[email protected]>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…hts-tests Signed-off-by: Mateusz Palczuk <[email protected]>
…with new standard Move message transformation to TrafficLightPublisherBase static member functions Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
…sts to new file Signed-off-by: Mateusz Palczuk <[email protected]>
…to RJD-1057-traffic-lights-tests Signed-off-by: Mateusz Palczuk <[email protected]>
TauTheLepton
added
wait for regression test
bump patch
|
No regressions confirmed here |
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Change 'random' numbers to round ones like one second or half a second Signed-off-by: Mateusz Palczuk <[email protected]>
Add clear thresholds for tests with explanations and use these thresholds instead of hardcoded values Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
… instead of "awf/universe" Signed-off-by: Mateusz Palczuk <[email protected]>
Make the variables const and add scope for subscribers so they stop listening (only in tests with more than one subscriber + remove .reset() as scopes take care of that Signed-off-by: Mateusz Palczuk <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This pull request is a continuation of #1406.
It adds tests for the new implementation of the traffic lights.
After changes requested review in #1406 and other:
In order to make it possible to test the correctness of the generation the messages:
autoware_auto_perception_msgs::msg::TrafficSignalArrayautoware_perception_msgs::msg::TrafficSignalArrayautoware_perception_msgs::msg::TrafficLightGroupArraytraffic_simulator_msgs::msg::TrafficLightArrayV1from
simulation_api_schema::UpdateTrafficLightsRequest, new static method has been extracted:scenario_simulator_v2/simulation/traffic_simulator/include/traffic_simulator/traffic_lights/traffic_light_publisher.hpp
Lines 54 to 56 in e6bf741
In traffic_light_publisher.cpp can be found definitions of methods used in tests.
Background
This pull request is one of many that aim to modularize the scenario_simulator_v2.
Details
In the previous pull request, a new implementation of traffic lights has been added and tests developed for the previous implementation have been deleted.
This pull request introduces tests for the new implementation of traffic lights. These changes have been split into two PRs, because of the amount of changes. If these changes (this PR and the previous one) were introduced in one PR, it would have been very large (>2000 additions).
References
INTERNAL LINK
Destructive Changes
Known Limitations