Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH-643] Improve Project overview page load perf #5774

Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the ProjectOverviewPage component to include improved loading states, conditional rendering based on project activity, and a more structured layout for displaying project analytics.

Detailed summary

  • Introduced GenericLoadingPage for loading states.
  • Added Suspense for asynchronous data fetching.
  • Reorganized rendering logic based on isActive status.
  • Improved layout structure with flexbox and conditional components.
  • Streamlined rendering of analytics cards and empty states.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 17, 2024

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 123435b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:30pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 4:30pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 4:30pm
wallet-ui ⬜️ Skipped (Inspect) Dec 17, 2024 4:30pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 14:43 Inactive
@MananTank MananTank marked this pull request as ready for review December 17, 2024 14:43
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024
Copy link
Member Author

MananTank commented Dec 17, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 12-17-_dash-643_improve_project_overview_page_load_perf branch from 8126997 to 4698ea5 Compare December 17, 2024 14:43
@MananTank MananTank changed the base branch from 12-17-_dash-634_remove_framer-motion_package_usage to main December 17, 2024 14:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 14:43 Inactive
Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 626 ms (+48.9% 🔺) 1.6 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 1.2 s (-3.93% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 67 ms (+91.83% 🔺) 179 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (-10.27% 🔽) 32 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 98 ms (+7.19% 🔺) 480 ms

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (e63e6da) to head (123435b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5774   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e63e6da
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link

graphite-app bot commented Dec 17, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ProjectOverviewPage` component by integrating a loading state with `Suspense`, restructuring the layout, and improving the conditional rendering of analytics components based on project activity.

### Detailed summary
- Added `Suspense` for loading state using `GenericLoadingPage`.
- Refactored layout to use a flexbox structure.
- Enhanced conditional rendering for `ProjectAnalytics` and `EmptyState`.
- Improved user statistics and charts display logic.
- Streamlined the rendering of various analytics cards.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-17-_dash-643_improve_project_overview_page_load_perf branch from 4698ea5 to 123435b Compare December 17, 2024 16:22
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 16:22 Inactive
@graphite-app graphite-app bot merged commit 123435b into main Dec 17, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-17-_dash-643_improve_project_overview_page_load_perf branch December 17, 2024 16:31
@vercel vercel bot temporarily deployed to Production – wallet-ui December 17, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 17, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 17, 2024 16:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants