Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH-605] Add profile OG image #5775

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the GradientAvatar component to utilize the new GradientBlobbie component for rendering gradients, while also enhancing the Open Graph image generation for user profiles.

Detailed summary

  • Removed url-utils.ts and profile.tsx files.
  • Updated page.tsx to use title and description variables directly.
  • Introduced GradientBlobbie component with gradient logic.
  • Modified GradientAvatar to use GradientBlobbie for fallback rendering.
  • Enhanced Open Graph image generation with new imports and logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: e71260e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 15:53 Inactive
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 4:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 4:59pm
wallet-ui ⬜️ Skipped (Inspect) Dec 17, 2024 4:59pm

Copy link

linear bot commented Dec 17, 2024

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 15:53 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024
Copy link
Member Author

MananTank commented Dec 17, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 17, 2024 15:53
@MananTank MananTank force-pushed the 12-17-_dash-605_add_profile_og_image branch from 41e0c25 to e71260e Compare December 17, 2024 15:54
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 15:54 Inactive
@MananTank MananTank changed the base branch from 12-17-_dash-643_improve_project_overview_page_load_perf to main December 17, 2024 15:54
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 15:54 Inactive
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (4d89116) to head (6e2e426).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5775   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4d89116
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 2.7 s (+7.53% 🔺) 3.6 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 5.3 s (-26.55% 🔽) 7.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 244 ms (-30.29% 🔽) 355 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 267 ms (+263.36% 🔺) 277 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 1.2 s (+145.37% 🔺) 1.6 s

Copy link

graphite-app bot commented Dec 17, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on refactoring the handling of gradients for avatars and updating the Open Graph image generation for user profiles. It introduces a new `GradientBlobbie` component and modifies the `GradientAvatar` to use this new component, enhancing the visual representation of user profiles.

### Detailed summary
- Deleted `url-utils.ts` and `profile.tsx` files.
- Introduced `title` and `description` variables in the profile page response.
- Created `GradientBlobbie` component for gradient backgrounds.
- Removed gradient logic from `GradientAvatar` and used `GradientBlobbie` instead.
- Updated Open Graph image generation to include `GradientBlobbie` for users without an ENS image.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-17-_dash-605_add_profile_og_image branch from e71260e to 6e2e426 Compare December 17, 2024 16:50
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 16:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 16:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 16:50 Inactive
@graphite-app graphite-app bot merged commit 6e2e426 into main Dec 17, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-17-_dash-605_add_profile_og_image branch December 17, 2024 17:00
@vercel vercel bot temporarily deployed to Production – docs-v2 December 17, 2024 17:00 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 17, 2024 17:00 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 17, 2024 17:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants