Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DASH-634] Remove framer-motion package usage #5773

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[DASH-634] Remove framer-motion package usage #5773

merged 1 commit into from
Dec 17, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 17, 2024 •
edited by pr-codex bot
Loading

Problem solved

Note: can't remove the package from package.json because chakra has peer dependency on it

PR-Codex overview

This PR focuses on refactoring components to simplify the structure and improve readability by removing unnecessary animations and making adjustments to props.

Detailed summary

  • Updated guides.map to use a more concise arrow function syntax in guide-showcase.tsx.
  • Removed index prop from GuideCard interface.
  • Replaced AnimatePresence with a simple <div> in EventsFeed, LatestEvents, and PermissionsTable.
  • Simplified SimpleGrid components by removing motion properties, using as="li" instead.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:49pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 4:49pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 4:49pm
wallet-ui ⬜️ Skipped (Inspect) Dec 17, 2024 4:49pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 14:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 14:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 14:22 Inactive
@linear Linear
Copy link

linear bot commented Dec 17, 2024

DASH-634 Remove framer-motion package usage from dashboard

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4d89116

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review December 17, 2024 14:22
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Dec 17, 2024 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (ae7d5f2) to head (4d89116).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5773   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ae7d5f2
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 2.9 s (+23.7% 🔺) 3.8 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 7 s (-1.65% 🔽) 9.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 194 ms (-23.22% 🔽) 306 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 247 ms (+192.67% 🔺) 257 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 746 ms (-10.76% 🔽) 1.2 s

@MananTank MananTank mentioned this pull request Dec 17, 2024
Merged
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 17, 2024 •
edited
Loading

Merge activity

@MananTank
[DASH-634] Remove framer-motion package usage (#5773)
4d89116 
## Problem solved

Note: can't remove the package from package.json because chakra has peer dependency on it

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the presentation of components by removing unnecessary animations and simplifying the structure of several components, specifically in the `GuideCard`, `EventsFeed`, and `PermissionsTable`.

### Detailed summary
- Changed `guides.map` to use a more concise arrow function syntax.
- Removed `index` prop from `GuideCardProps`.
- Replaced `AnimatePresence` wrappers with simple `div` elements in `EventsFeed` and `LatestEvents`.
- Simplified animation logic in `EventsFeedItem` and `PermissionsItem` by removing motion properties and replacing them with simple list item (`li`) tags.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-17-_dash-634_remove_framer-motion_package_usage branch from 56c1aa3 to 4d89116 Compare December 17, 2024 16:41
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 16:41 Inactive
@graphite-app graphite-app bot merged commit 4d89116 into main Dec 17, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-17-_dash-634_remove_framer-motion_package_usage branch December 17, 2024 16:49
@vercel vercel bot temporarily deployed to Production – docs-v2 December 17, 2024 16:49 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 17, 2024 16:49 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 17, 2024 16:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel jakubkrehel is a code owner

Assignees

@MananTank MananTank

Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MananTank @jnsdls