Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground] Chain components #5678

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Dec 10, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new Chain section in the application, enhancing the UI with components for displaying chain icons and names. It also adds metadata for the Chain page and improves the handling of chain icons.

Detailed summary

  • Added a new Chain entry in navLinks.ts.
  • Created a new page.tsx for Chain with metadata and main content.
  • Implemented ChainIconBasic and ChainNameBasic components in chain-examples.tsx.
  • Updated icon resolution logic in token/page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 10, 2024

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 498a26e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:17pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:17pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:17pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:17pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 10, 2024 14:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 10, 2024 14:12 Inactive
Copy link

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 10, 2024 14:12 Inactive
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Dec 10, 2024
@kien-ngo kien-ngo changed the title update [Playground] Chain components Dec 10, 2024
Copy link
Contributor Author

kien-ngo commented Dec 10, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (8761fe6) to head (498a26e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5678      +/-   ##
==========================================
- Coverage   52.93%   52.89%   -0.05%     
==========================================
  Files        1098     1099       +1     
  Lines       58982    59010      +28     
  Branches     4794     4791       -3     
==========================================
- Hits        31225    31211      -14     
- Misses      27039    27083      +44     
+ Partials      718      716       -2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8761fe6
packages 49.99% <ø> (-0.06%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 723 ms (+33.06% 🔺) 1.7 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 1.4 s (+6.4% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 196 ms (+177.86% 🔺) 307 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (-74.88% 🔽) 23 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 183 ms (+49.28% 🔺) 563 ms

@kien-ngo kien-ngo force-pushed the kien/playground-token-components-CNCT-2622 branch from 30ab455 to 56833ce Compare December 10, 2024 14:29
@kien-ngo kien-ngo force-pushed the kien/playground-chain-components-CNCT-2623 branch from ff7bc85 to d13c6f8 Compare December 10, 2024 14:29
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 10, 2024 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 10, 2024 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 10, 2024 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 02:38 Inactive
@kien-ngo kien-ngo changed the base branch from kien/playground-token-components-CNCT-2622 to graphite-base/5678 December 13, 2024 02:38
Copy link

graphite-app bot commented Dec 13, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces new `Chain` components to enhance the user interface for blockchain applications, allowing for the display of chain icons and names. It includes new pages and components that integrate these features into the existing playground web application.

### Detailed summary
- Added a new `Chain` entry in `navLinks.ts`.
- Created a new page in `page.tsx` for `Chain` components with metadata.
- Integrated `ThirdwebProvider`, `APIHeader`, `ChainIconBasic`, and `ChainNameBasic` components.
- Implemented `ChainIconBasic` and `ChainNameBasic` components in `chain-examples.tsx` to showcase chain icons and names.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants