-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Playground] Add Token components, fix links #5677
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
code={`import { TokenProvider, TokenName } from "thirdweb/react"; | ||
|
||
function App() { | ||
return ( | ||
<TokenProvider | ||
address={NATIVE_TOKEN_ADDRESS} | ||
client={THIRDWEB_CLIENT} | ||
chain={ethereum} | ||
> | ||
<TokenName loadingComponent={<span>Loading...</span>} /> | ||
</TokenProvider> | ||
) | ||
}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code example shows NATIVE_TOKEN_ADDRESS
while the preview component uses USDC_ADDRESS
, creating a mismatch between the example and its implementation. For consistency, update the code example to use USDC_ADDRESS
to accurately reflect what's being rendered in the preview.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acknowleded
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5677 +/- ##
=======================================
Coverage 52.85% 52.85%
=======================================
Files 1098 1098
Lines 58976 58976
Branches 4788 4788
=======================================
Hits 31173 31173
Misses 27087 27087
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more. |
e2424f5
to
bfe0d2c
Compare
30ab455
to
56833ce
Compare
5e8cbb1
to
dc3ee20
Compare
76e38a2
to
2fccfc0
Compare
dc3ee20
to
59a3d10
Compare
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces new components and updates existing ones for token management in a React application. It enhances the user interface by adding a `Token` navigation link, updating documentation links, and implementing several new token-related components for better usability. ### Detailed summary - Added a new navigation link for `Token` in `navLinks.ts`. - Updated documentation links in `page.tsx` for `connect/ui` and `nft`. - Created a new `page.tsx` for token components with detailed descriptions and examples. - Added an SVG for `usdc` in `public/usdc.svg`. - Implemented multiple token components in `token-examples.tsx`, including `TokenImageBasic`, `TokenImageOverride`, `TokenNameBasic`, `TokenSymbolBasic`, and `TokenCard`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
59a3d10
to
ce9b6f1
Compare
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new `Token` navigation link, updates documentation links, and adds a new SVG file. It also implements a `Token` components page with multiple examples and components for displaying tokens, enhancing the UI for token-related functionalities. ### Detailed summary - Added a new navigation link for `Token` in `navLinks.ts`. - Updated documentation links in `page.tsx` for better references. - Introduced a new SVG file for `usdc`. - Created a new `Token` components page with examples for: - `TokenImageBasic` - `TokenImageOverride` - `TokenNameBasic` - `TokenSymbolBasic` - `TokenCard` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ce9b6f1
to
64f4103
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces new components and updates documentation related to token management in a web application. It enhances the user interface for displaying token information and adds a new token page.
Detailed summary
navLinks.ts
.docsLink
inpage.tsx
files for better documentation.Token
page with components for displaying token details.public/usdc.svg
.token-examples.tsx
.