[SDK] Fix caching issue with headless UI when custom resolvers are used #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2fccfc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
joaquim-verges,
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5657 +/- ##
==========================================
+ Coverage 51.42% 51.52% +0.09%
==========================================
Files 1093 1093
Lines 57524 57588 +64
Branches 4723 4755 +32
==========================================
+ Hits 29583 29671 +88
+ Misses 27225 27200 -25
- Partials 716 717 +1
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
requested changes
Dec 9, 2024
kien-ngo
force-pushed
the
kien/cnct-2591_fix-caching-issue
branch
from
63e00b0 to
000438f
Compare
kien-ngo
force-pushed
the
kien/cnct-2591_fix-caching-issue
branch
from
000438f to
65bb12e
Compare
kien-ngo
force-pushed
the
kien/cnct-2591_fix-caching-issue
branch
from
b70d69c to
7bb43c0
Compare
kien-ngo
force-pushed
the
kien/cnct-2591_fix-caching-issue
branch
from
7bb43c0 to
76e38a2
Compare
gregfromstl
approved these changes
Dec 11, 2024
Merge activity
|
…ed (#5657) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR addresses caching issues in headless components and enhances code coverage. It introduces the `getFunctionId` utility in various components to improve resolver handling for names and symbols. ### Detailed summary - Added `getFunctionId` to various components for handling resolvers. - Updated `NFTName`, `NFTDescription`, and `NFTMedia` to use `getFunctionId` instead of `toString()`. - Enhanced `ChainIcon`, `TokenIcon`, `ChainName`, and `TokenName` to include resolver handling. - Introduced `fetchChainName` and `fetchTokenName` for improved name resolution. - Added tests for `fetchChainName`, `fetchTokenName`, `fetchTokenSymbol`, and their respective query keys. - Updated `TokenSymbol` to utilize `fetchTokenSymbol` and improved resolver handling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/cnct-2591_fix-caching-issue
branch
from
76e38a2 to
2fccfc0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on fixing caching issues for headless components and improving code coverage in the
thirdwebpackage.Detailed summary
nameResolveranddescriptionResolverinNFTNameandNFTDescriptionto usegetFunctionId.NFTMediato utilizegetFunctionIdformediaResolver.fetchChainNameandfetchTokenNamefunctions for better name resolution.fetchChainName,fetchTokenName, andfetchTokenSymbolto ensure proper functionality.getQueryKeysto handle resolvers more effectively in bothTokenNameandTokenSymbol.