Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Examples for Wallet components #5692

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Dec 11, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new Wallet navigation link and adds a Wallet components page, featuring various wallet-related UI components. It enhances the user interface for crypto wallet applications by integrating new examples and components.

Detailed summary

  • Added a new navigation link for Wallet in navLinks.ts.
  • Created a new page in page.tsx for Wallet Components with metadata.
  • Implemented APIHeader for the wallet page with a description and links.
  • Added sections for WalletIconBasic, WalletNameBasic, and WalletNameFormat components.
  • Developed WalletIconBasic, WalletNameBasic, and WalletNameFormat components in wallet-examples.tsx with usage examples.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 11, 2024

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 11:28am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 14, 2024 11:28am
thirdweb-www ⬜️ Skipped (Inspect) Dec 14, 2024 11:28am
wallet-ui ⬜️ Skipped (Inspect) Dec 14, 2024 11:28am

Copy link
Contributor Author

kien-ngo commented Dec 11, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 11, 2024 10:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 11, 2024 10:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 11, 2024 10:43 Inactive
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 2b5080d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Dec 11, 2024
Comment on lines 14 to 16
title: "NFT Components",
description:
"Elevate your NFT marketplace with our React headless UI components, engineered for seamless digital asset transactions. These customizable, zero-styling components simplify NFT interactions while giving developers complete freedom to craft their perfect user interface.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page metadata references NFT Components in both the title and description, but this page is specifically for Wallet components. The metadata should be updated to accurately reflect the page content:

Suggested change
title: "NFT Components",
description:
"Elevate your NFT marketplace with our React headless UI components, engineered for seamless digital asset transactions. These customizable, zero-styling components simplify NFT interactions while giving developers complete freedom to craft their perfect user interface.",
title: "Wallet Components",
description:
"Enhance your application with React headless UI components for wallet interactions. These customizable, zero-styling components simplify wallet connections while giving developers complete freedom to craft their perfect user interface.",

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (+0.06% 🔺) 899 ms (+0.06% 🔺) 2.1 s (-24.8% 🔽) 3 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 6.1 s (+14.04% 🔺) 8.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 287 ms (+1.36% 🔺) 398 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 88 ms (+15.79% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 978 ms (+7.6% 🔺) 1.4 s

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (5be197b) to head (2b5080d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5692   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files        1101     1101           
  Lines       59079    59079           
  Branches     4809     4809           
=======================================
  Hits        31322    31322           
  Misses      27039    27039           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5be197b
packages 50.15% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@kien-ngo kien-ngo force-pushed the kien/headless-ui-wallet-component branch from f962fa4 to 89967f0 Compare December 11, 2024 11:02
@kien-ngo kien-ngo force-pushed the kien/playground-wallet-components-CNCT-2620 branch from 5ab5ffc to d926546 Compare December 11, 2024 11:02
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 11, 2024 11:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 11, 2024 11:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 11, 2024 11:02 Inactive
@kien-ngo kien-ngo changed the title update Playground: Examples for Wallet components Dec 11, 2024
@kien-ngo kien-ngo force-pushed the kien/headless-ui-wallet-component branch 2 times, most recently from 6dce640 to 9b5b581 Compare December 11, 2024 18:39
@kien-ngo kien-ngo force-pushed the kien/playground-wallet-components-CNCT-2620 branch from d926546 to da8f958 Compare December 11, 2024 18:39
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 11, 2024 18:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 11, 2024 18:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 11, 2024 18:39 Inactive
@kien-ngo kien-ngo force-pushed the kien/headless-ui-wallet-component branch from 9b5b581 to 1250074 Compare December 12, 2024 05:30
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 14, 2024 10:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 14, 2024 10:02 Inactive
@joaquim-verges joaquim-verges changed the base branch from kien/headless-ui-wallet-component to graphite-base/5692 December 14, 2024 10:11
@kien-ngo kien-ngo force-pushed the kien/playground-wallet-components-CNCT-2620 branch from 96fd057 to 53c3c7b Compare December 14, 2024 10:11
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 14, 2024 10:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 14, 2024 10:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 14, 2024 10:12 Inactive
@kien-ngo kien-ngo force-pushed the kien/playground-wallet-components-CNCT-2620 branch from 53c3c7b to 657fece Compare December 14, 2024 10:44
@kien-ngo kien-ngo changed the base branch from graphite-base/5692 to main December 14, 2024 10:44
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 14, 2024 10:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 14, 2024 10:44 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 14, 2024 10:44 Inactive
Copy link

graphite-app bot commented Dec 14, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `Wallet` navigation link and implements a new `Wallet` page with components for displaying wallet icons and names, enhancing the user interface for crypto wallet applications.

### Detailed summary
- Added a new navigation link for `Wallet`.
- Created `page.tsx` for the `Wallet` section with metadata and layout.
- Implemented `APIHeader` for the `Wallet` page.
- Added three components: `WalletIconBasic`, `WalletNameBasic`, and `WalletNameFormat` in `wallet-examples.tsx`.
- Each component includes a description and code example for usage.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/playground-wallet-components-CNCT-2620 branch from 657fece to 2b5080d Compare December 14, 2024 11:27
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 14, 2024 11:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 14, 2024 11:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 14, 2024 11:27 Inactive
@graphite-app graphite-app bot merged commit 2b5080d into main Dec 14, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/playground-wallet-components-CNCT-2620 branch December 14, 2024 11:29
@vercel vercel bot temporarily deployed to Production – wallet-ui December 14, 2024 11:29 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www December 14, 2024 11:29 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 14, 2024 11:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants