Mention auto-complete #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SatsAllDay
force-pushed
the
mention-autocomplete
branch
2 times, most recently
from
b725931 to
bc39ec4
Compare
* support custom limit on topUsers query * hot keys for selecting user suggestion in markdown input * query top stackers for mentions with no search query * refactor UserSuggestion to help with reusability textarea-caret for placing the user suggest dropdown appropriately other various code cleanup items to make it easier to use off by one errors are fun! various code cleanup and reuse the UserSuggest component in InputUserSuggest to reduce duplication
SatsAllDay
force-pushed
the
mention-autocomplete
branch
from
bc39ec4 to
0ed4d03
Compare
|
Demo cc @ekzyis I believe this captures all of your input Ignore the delay on searching users, that's just my slow machine :P sn-mention-autocomplete.mov |
|
Great work! |
|
Thank you! This is going to be a big release! |
|
YUGE 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #529
Support mention auto-complete in markdown input fields. Closely follows the suggestions in #529, which are largely inspired by GitHub's experience.
@is typed, show a list of top stackers for the day to pick from (5)@to search for similarly named users to pick from@e.g.x@@. Suggestions are based on the remaining mention text.