Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention autocompletes #529

Closed
huumn opened this issue Sep 28, 2023 · 6 comments · Fixed by #532
Closed

mention autocompletes #529

huumn opened this issue Sep 28, 2023 · 6 comments · Fixed by #532
Labels
feature new product features that weren't there before

Comments

@huumn
Copy link
Member

huumn commented Sep 28, 2023

It'd be nice in a post or comment when @ing someone to have some help getting the spelling right.

@ekzyis ekzyis added the feature new product features that weren't there before label Sep 30, 2023
@SatsAllDay
Copy link
Contributor

Any specific UX in mind for this?

@SatsAllDay
Copy link
Contributor

SatsAllDay commented Oct 1, 2023

I very quickly whipped up this. I haven't even checked the code in, it's so rough lol but is this sorta what you're looking for?

EDIT: Code checked in here #532

sn.mention.autocomplete.mov

@ekzyis
Copy link
Member

ekzyis commented Oct 1, 2023

What I had in mind - inspired by Github again:

  • immediately shows up after pressing @
  • you can use arrow keys
  • you can use tab to select
  • does not show up if anything comes before @ like this: x@
  • also shows up if you press backspace and cursor is next to @ again
  • does not show up if you use arrow keys or mouse to move cursor next to @
2023-10-01.11-22-43.mp4

i would also prefer if it shows up next to the cursor and the first entry is marked as selected. this makes it more clear that arrow navigation and tab completion is possible imo

@SatsAllDay
Copy link
Contributor

Great feedback! I had most of this in mind, just hadn't gotten there yet. Thank you for formally writing it all out, I think that's very helpful

@SatsAllDay
Copy link
Contributor

@ekzyis thoughts on which users should show up when you just type @? Options:

  1. Random users
  2. Users with most comments in some timeframe
  3. Users with most posts in some timeframe
  4. Top stackers in some timeframe
  5. Most mentioned users in some timeframe
  6. Other?

@huumn
Copy link
Member Author

huumn commented Oct 3, 2023

Top stackers in some timeframe

I like top stackers

Most mentioned users in some timeframe

Those poor souls lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new product features that weren't there before
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants