Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RBAC display name for unresolved identities and groups #2058

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

joelhulen
Copy link
Contributor

@joelhulen joelhulen commented Dec 11, 2024

Update RBAC display name for unresolved identities and groups

The issue or feature being addressed

When using virtual security groups or referencing users and roles that no longer exist, the identity information returned by Microsoft Graph is null. This causes an error when displaying the RBAC list within the Management Portal, plus one cannot tell which identity is listed within the RBAC list.

Details on the issue fix or feature implementation

This PR ensures that unmatched Entra ID objects are returned when calling GetObjectsByIds, setting the display name to the object ID.

Also updated the breaking changes document to document a change in RBAC permissions required on the auth Key Vault account.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • This PR needs to be cherry-picked into at least one release branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.

@ciprianjichici ciprianjichici merged commit 2d32d35 into main Dec 11, 2024
9 checks passed
@ciprianjichici ciprianjichici deleted the jdh-rbac-display branch December 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants