Merge pull request #2058 from solliancenet/jdh-rbac-display

Update RBAC display name for unresolved identities and groups
solliancenet · Dec 11, 2024 · 2d32d35 · 2d32d35
2 parents 2687cb2 + 02aea29
commit 2d32d35
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/docs/release-notes/breaking-changes.md b/docs/release-notes/breaking-changes.md
@@ -30,6 +30,10 @@ Agent tools are now an array of AgentTool objects rather than a dictionary.
 
 When defining tools for an agent, each tool now requires a `package_name` property. This property is used to identify the package that contains the tool's implementation. If the tool is internal, the `package_name` should be set to `FoundationaLLM`, if the tool is external, the `package_name` should be set to the name of the external package.
 
+#### Security-related changes
+
+The **Authorization API** now requires the ability to write to the Key Vault account contained within the auth resource group. Currently, the Authorization APIs managed identity is assigned to the `Key Vault Secrets User` role on the Key Vault account. This role assignment must be updated to include the `Key Vault Secrets Officer` role in addition to the user role.
+
 #### Renamed classes
 
 The following classes have been renamed:
@@ -54,7 +58,6 @@ The `/instances/{instanceId}/sessions/{sessionId}/message/{id}/rate` endpoint ha
 > [!NOTE]
 > Please note that both properties are nullable. Set them to null to clear out the rating and comments.
 
-
 ## Starting with 0.8.4
 
 ### Configuration changes

diff --git a/src/dotnet/Common/Services/Security/MicrosoftGraphIdentityManagementService.cs b/src/dotnet/Common/Services/Security/MicrosoftGraphIdentityManagementService.cs
@@ -133,6 +133,20 @@ public async Task<List<ObjectQueryResult>> GetObjectsByIds(ObjectQueryParameters
                 });
             }
 
+            // Add to the results an `ObjectQueryResult` object for any `parameters.Ids` that are not in the results.
+            foreach (var id in parameters.Ids)
+            {
+                if (results.All(x => x.Id != id))
+                {
+                    results.Add(new ObjectQueryResult
+                    {
+                        Id = id,
+                        DisplayName = id,
+                        ObjectType = ObjectTypes.Other
+                    });
+                }
+            }
+
             return results;
         }
 

diff --git a/src/ui/ManagementPortal/components/RoleAssignmentsTable.vue b/src/ui/ManagementPortal/components/RoleAssignmentsTable.vue
@@ -138,7 +138,7 @@
 				<template #body="{ data }">
 					<Button
 						link
-						:aria-label="`Delete role assignment for ${data.principal.display_name}`"
+						:aria-label="`Delete role assignment ${data.principal?.display_name? 'for ' + data.principal?.display_name : ''}`"
 						@click="roleAssignmentToDelete = data"
 					>
 						<i class="pi pi-trash" style="font-size: 1.2rem" aria-hidden="true"></i>