Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RBAC display name for unresolved identities and groups #2058

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Update RBAC display name for unresolved identities and groups #2058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e8570a
Return the ID of any object not found within the Graph API
joelhulen Dec 11, 2024
68fbb6b
Handle null principals
joelhulen Dec 11, 2024
02aea29
Update breaking changes
joelhulen Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/release-notes/breaking-changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ Agent tools are now an array of AgentTool objects rather than a dictionary.

When defining tools for an agent, each tool now requires a `package_name` property. This property is used to identify the package that contains the tool's implementation. If the tool is internal, the `package_name` should be set to `FoundationaLLM`, if the tool is external, the `package_name` should be set to the name of the external package.

#### Security-related changes

The **Authorization API** now requires the ability to write to the Key Vault account contained within the auth resource group. Currently, the Authorization APIs managed identity is assigned to the `Key Vault Secrets User` role on the Key Vault account. This role assignment must be updated to include the `Key Vault Secrets Officer` role in addition to the user role.

#### Renamed classes

The following classes have been renamed:
Expand All @@ -54,7 +58,6 @@ The `/instances/{instanceId}/sessions/{sessionId}/message/{id}/rate` endpoint ha
> [!NOTE]
> Please note that both properties are nullable. Set them to null to clear out the rating and comments.


## Starting with 0.8.4

### Configuration changes
Expand Down
14 changes: 14 additions & 0 deletions src/dotnet/Common/Services/Security/MicrosoftGraphIdentityManagementService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,20 @@ public async Task<List<ObjectQueryResult>> GetObjectsByIds(ObjectQueryParameters
});
}

// Add to the results an `ObjectQueryResult` object for any `parameters.Ids` that are not in the results.
foreach (var id in parameters.Ids)
{
if (results.All(x => x.Id != id))
{
results.Add(new ObjectQueryResult
{
Id = id,
DisplayName = id,
ObjectType = ObjectTypes.Other
});
}
}

return results;
}

Expand Down
2 changes: 1 addition & 1 deletion src/ui/ManagementPortal/components/RoleAssignmentsTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
<template #body="{ data }">
<Button
link
:aria-label="`Delete role assignment for ${data.principal.display_name}`"
:aria-label="`Delete role assignment ${data.principal?.display_name? 'for ' + data.principal?.display_name : ''}`"
@click="roleAssignmentToDelete = data"
>
<i class="pi pi-trash" style="font-size: 1.2rem" aria-hidden="true"></i>
Expand Down
Loading