[Admin][Products] Add product properties create/edit flow to admin #6011
Conversation
MadelineCollier
changed the title
This builds off of the excellent work started in solidusio#5885 and in solidusio#5926 to build out the create/edit/update flow for product properties in the new admin. I've added a request spec that was missing and tweaked a few other things.
MadelineCollier
force-pushed
the
admin-product-properties-create-edit
branch
from
22b5594 to
01325f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6011 +/- ##
==========================================
- Coverage 89.46% 87.81% -1.65%
==========================================
Files 782 476 -306
Lines 18001 11658 -6343
==========================================
- Hits 16104 10238 -5866
+ Misses 1897 1420 -477 ☔ View full report in Codecov by Sentry. |
|
@MadelineCollier can we wait until #6014 has been finalized and merged? This contains everything we need to use semantic links and form redirects. I am happy to help update this PR (it's not much actually) afterwards. |
For sure, I can hold off and integrate it later today (assuming the other PR is merged today). Thanks for your work on solving that issue by the way. |
There was a problem hiding this comment.
I tabled #6014 (comment)
so this is ready to be merged. Thanks for the patience 🙏🏻
|
Thanks for taking this to the 🏁 @MadelineCollier! Great work here! |
Summary
This change addresses #5857
This builds off of the excellent work done by @Astr0surf3r in #5885 and by @forkata in #5926 to build out the create/edit/update flow for product properties in the new admin.
I've added a request spec that was missing and tweaked a few other things.
Screenshots
Screen.Recording.2024-12-05.at.1.38.45.PM.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: