[Admin][Product] fix properties edit action in admin panel part of the issue #5857 #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
tvdeyen
reviewed
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5885 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 783 783
Lines 17994 17994
=======================================
Hits 16113 16113
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
|
@Astr0surf3r please use rebase to update your branch as mentioned in the contribution guidelines |
github-actions
bot
removed
the
changelog:solidus_backend
@tvdeyen I hope now the PR is cleaner than before ... if need something else to do (I have read the guidelines) let me know please I really appreciate all your tips and messages to give a hand to your great project NOTE: now the PR is out-of-date with the base branch for this reason launched an |
This commit adds an introductory section telling the reader how the migration process works. It also adds a last section telling the reader to remove any ineligible adjustments from their database. Lastly, it corrects the location of Spree configuration from the `solidus_promotions` initializer to the `spree.rb` initializer.
We don't want to include `solidus_promotions` as a dependency in `solidus` yet, but we do want to release the gem, so it should appear in the all the lists of Solidus sub-gems.
This code has been automatically generated by our 'Prepare release' GitHub action. The actual release is not part of the automation, and it still needs to be manually done by a maintainer.
Due to the top level constant in testing.rake the release task was also trying to release frontend. Using a local variable instead.
This code has been automatically generated by our 'Prepare post-release' GitHub action. Make sure that: - [ ] The new release has been published, along with its tag. See https://github.com/solidusio/solidus/releases/tag/v4.4.0 - [ ] The corresponding patch branch exists. See https://github.com/solidusio/solidus/tree/v4.4 - [ ] The corresponding backport-v4.4 label exists. See https://github.com/solidusio/solidus/labels
github-actions
bot
added
the
changelog:solidus_core
github-actions
bot
removed
the
changelog:solidus_core
|
@Astr0surf3r please rebase with latest main branch and make one commit containing only your changes. Thanks |
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this pull request
Dec 5, 2024
This builds off of the excellent work done by @Astr0surf3r in solidusio#5885 and by @forkata in solidusio#5926 to build out the create/edit/update flow for product properties in the new admin. I've added a request spec that was missing and tweaked a few other things.
3 tasks
|
The work started here has been pulled into #6011. Thanks for your contribution @Astr0surf3r ! |
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this pull request
Dec 5, 2024
This builds off of the excellent work started in solidusio#5885 and in solidusio#5926 to build out the create/edit/update flow for product properties in the new admin. I've added a request spec that was missing and tweaked a few other things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have just downloaded the gem to fix the issue #5857 and I found in admin panel an error in Property Types (in your demo the error appear as well)
After I added a new one property and no issue came up clicking in the
+ Add newbutton of the/admin/propertiespagebut after I saved it
I couldn't edit it because an error appear
so to fix this I add the show action in the
Spree::Admin::PropertiesControllerand create an rspec file I hope this can help your great workI have written a thorough PR description.
I have kept my commits small and atomic.
I have used clear, explanatory commit messages.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.