[Admin] Add product properties admin UI #5926
Conversation
The default behaviour is to use the plural version of the model human name, which is defined in core as "Property Types", however the navigation in the new admin has different nomenclature for this model. This change ensures we use the same language as the navigation for consistency.
Adds the `New` component and renders it on the page. It doesn't actually work yet! Co-authored-by: benjamin wil <[email protected]>
Previously this would force the development server to run on 3000, but it is useful to be able to override that. Co-authored-by: Harmony Evangelina <[email protected]>
This completes the ability to create a new product property in the new admin UI. Co-authored-by: Harmony Evangelina <[email protected]>
forkata
force-pushed
the
issues/5857/add-product-properties-admin
branch
from
b2ea1b7 to
7a8bbd6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5926 +/- ##
==========================================
- Coverage 89.53% 89.52% -0.02%
==========================================
Files 782 783 +1
Lines 17980 18015 +35
==========================================
+ Hits 16099 16128 +29
- Misses 1881 1887 +6 ☔ View full report in Codecov by Sentry. |
|
Probably a rebuild of #5892 |
Oh no! I didn't realize that was happening already 😞 We have this as an issue and on the Project board, but I guess not many people are aware of that. |
|
How do we want to proceed here? The other PR needs a little love, but I'm not sure how much the two differ. |
|
@jarednorman I can pull the changes from the other PR and rebase them if the owner of that doesn't come back? Otherwise happy to abandon these changes here, as from what I could tell that PR has everything this has and also the updating done. |
Also happy to collate the two as I'm already in this section of the site if you have better stuff to do @forkata just let me know what you prefer! |
|
Yeah, I'm happy for @MadelineCollier to do whatever needs to be done here and carry this over the finish line. |
|
Hey @MadelineCollier, if you are okay taking this over, that would be much appreciated ❤️ I might not have a chance to revisit this work until next week so happy to pass it on to you if you have time! |
|
For sure, I'll handle it today! |
This builds off of the excellent work done by @Astr0surf3r in solidusio#5885 and by @forkata in solidusio#5926 to build out the create/edit/update flow for product properties in the new admin. I've added a request spec that was missing and tweaked a few other things.
|
The work started here has been pulled into #6011. Thanks guys! |
This builds off of the excellent work started in solidusio#5885 and in solidusio#5926 to build out the create/edit/update flow for product properties in the new admin. I've added a request spec that was missing and tweaked a few other things.
Summary
This change addresses #5857 and introduces a new UI for creating and
editing product properties in the new admin.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: