Add changeset for using RpcRequest and RpcResponse in RPC Subscriptions #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13363b7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 21, 2024
This was referenced Oct 21, 2024
mcintyre94
approved these changes
Oct 22, 2024
Merge activity
|
lorisleiva
added a commit
that referenced
this pull request
Oct 23, 2024
This PR changes the configs of the `executeRpcPubSubSubscriptionPlan` function such that it accepts a "Subscribe Request" as a `RpcRequest` object instead of a `subscribeMethodName` and `subscribeParams` duo. This mean we can now use the `RpcRequestTransformer` provided in a more idiomatic way. Note: A changeset for this PR is included in #3407.
lorisleiva
added a commit
that referenced
this pull request
Oct 23, 2024
This PR refactors the definition of a Response Transformer in the RPC Subscriptions architecture from `<T>(response: unknown, notificationName: string) => T;` to `RpcResponseTransformer`. That way, both the RPC and RPC Subscriptions architectures use the same interfaces for transforming requests and responses which means we can refactoring helper method like `getDefaultResponseTransformerForSolanaRpcSubscriptions` in a more composable way (using the `pipe` function like we did with default RPC Response Transformer). Note: A changeset for this PR is included in #3407.
lorisleiva
changed the base branch from
loris/use-rpc-request-in-plan-executor
to
graphite-base/3407
lorisleiva
added a commit
that referenced
this pull request
Oct 23, 2024
This PR replaces the `notificationName` and `params` arguments of the `RpcSubscriptionsPlanExecutor` function by a single `request` argument of type `RpcRequest`. This request argument is meant to represent the user intent to request a subscription from the RPC Subscriptions packages. Note: A changeset for this PR is included in #3407.
lorisleiva
force-pushed
the
loris/add-changeset-for-rpc-request-response-changes
branch
2 times, most recently
from
3b41daa
to
14ca5cc
Compare
lorisleiva
force-pushed
the
loris/add-changeset-for-rpc-request-response-changes
branch
from
14ca5cc
to
13363b7
Compare
lorisleiva
deleted the
loris/add-changeset-for-rpc-request-response-changes
branch
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a changeset combining several smaller changes in the previous PRs of this stack. That way, we provide a slightly more digest changelog.