-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable Node 23 CI tests #3395
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably just wait for this to be reverted in Node and for 23.0.1 to be published: nodejs/node#55414.
But like, whatever. Your choice. |
Yeah, OK, you're right this might take a while. With one small tweak: I changed 'current' to 22.x. |
This reverts commit c7ba1a8.
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Context: Two days ago Node officially released version 23 and updated the
Current
alias to point to this new stable version.Problem: This is causing our CI to fail in the following way: when running Jest unit tests, we get
No tests found, exiting with code 1
.It looks like
testMatch
gets some matches buttestRegex
no longer does. The reason this only starts failing in PRs (and not on themaster
branch) is because of Turbo caching. I tested this by created a new PR that only adds a comment to a package and that package CI now fails.Workaround: One temporary workaround is to comment out the current version on the CI Node matrix until Node v23 and Jest learn how to play nicely with each other. This is what this PR does.