Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable Node 23 CI tests #3395

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

lorisleiva
Copy link
Collaborator

@lorisleiva lorisleiva commented Oct 18, 2024

Context: Two days ago Node officially released version 23 and updated the Current alias to point to this new stable version.

Problem: This is causing our CI to fail in the following way: when running Jest unit tests, we get No tests found, exiting with code 1.

CleanShot 2024-10-18 at 09.51.17@2x.png

It looks like testMatch gets some matches but testRegex no longer does. The reason this only starts failing in PRs (and not on the master branch) is because of Turbo caching. I tested this by created a new PR that only adds a comment to a package and that package CI now fails.

Workaround: One temporary workaround is to comment out the current version on the CI Node matrix until Node v23 and Jest learn how to play nicely with each other. This is what this PR does.

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 865db38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lorisleiva lorisleiva marked this pull request as ready for review October 18, 2024 12:31
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably just wait for this to be reverted in Node and for 23.0.1 to be published: nodejs/node#55414.

@steveluscher
Copy link
Collaborator

But like, whatever. Your choice.

@steveluscher
Copy link
Collaborator

Yeah, OK, you're right this might take a while. With one small tweak: I changed 'current' to 22.x.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants