Move RpcRequest and RpcResponse types to rpc-spec-types #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dccdeba The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 17, 2024
lorisleiva
force-pushed
the
loris/remove-unused-rpcs-type
branch
from
290bef4
to
9b9a3b5
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
164e37c
to
ba813b0
Compare
lorisleiva
force-pushed
the
loris/remove-unused-rpcs-type
branch
3 times, most recently
from
1c68cd2
to
601d031
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
ba813b0
to
a9597b9
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
2 times, most recently
from
f1cee41
to
580ac5d
Compare
lorisleiva
force-pushed
the
loris/remove-unused-rpcs-type
branch
from
601d031
to
ba88104
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
580ac5d
to
b965d83
Compare
This was referenced Oct 21, 2024
mcintyre94
approved these changes
Oct 22, 2024
lorisleiva
changed the base branch from
loris/remove-unused-rpcs-type
to
graphite-base/3393
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
b965d83
to
dccdeba
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the goals of this stack is to eventually make
RpcRequestTransformersandRpcResponseTransformersusable on both RPC and RPC Subscriptions architectures. This was the original intention of therpc-transformerspackage which already hosts request and response transformers for both but with inconsistent types.As such, this PR aims to get closer to this goal by moving the
RpcRequest,RpcResponse,RpcRequestTransformerandRpcResponseTransformertypes from therpc-specpackage to therpc-spec-typespackage.As a reminder the
rpc-specandrpc-subscriptions-specpackages define the interfaces of the RPC and RPC Subscriptions architectures respectively, whereas, therpc-spec-typespackage is a utility package that is imported by both of the former packages.Note that, the
rpc-spec-typespackage is now being exported from the main library because re-exporting that package in bothrpcandrpc-subscriptionswould be problematic for the main library that re-exports both.Addresses #2983.