arrow2-convert migration 2: non-serde blueprint types
#3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🏹 arrow
teh-cmc
changed the title
teh-cmc
changed the title
arrow2-convert migration 2: non-serde blueprint types
teh-cmc
force-pushed
the
cmc/arrow2convert_be_gone_2
branch
from
5172b1a to
d5b5f3d
Compare
4 tasks
…ow2-convert free)
teh-cmc
force-pushed
the
cmc/arrow2convert_be_gone_2
branch
from
6cc01d7 to
e136da9
Compare
This was referenced Oct 17, 2023
teh-cmc
added a commit
that referenced
this pull request
Oct 18, 2023
… out dependencies (#3897) This introduces the `rust.attr.override_crate` attribute, which is necessary for the serde-codegen story. This attribute also allows us to generate some fundamental types such as `InstanceKey` directly into `re_types_core` rather than `re_types`, making it possible to reduce the number of crates that depend on the giant `re_types`. - The `AutoSpaceViews` & `PanelView` components are now back into their respective home (`re_viewport` & `re_viewer`, respectively). They were temporarily moved it because we had no support for `custom_crate`. They will be joined by their more complicated siblings in the next PR, which implements the necessary serde-codegen support. - `InstanceKey`, `Clear` and `ClearIsRecursive` are now generated into `re_types_core`. This allows `re_query`, `re_arrow_store` and `re_data_store` to drop their dependency on `re_types`. - Generated code now picks up arrow from `re_types_core::external` instead of importing it directly. This means crates hosting generated code are not forced into import `arrow2` directly. --- `arrow2-convert` migration PR series: - #3853 - #3855 - #3897 - #3902
teh-cmc
added a commit
that referenced
this pull request
Oct 19, 2023
…3902) This introduces the `rust.attr.serde_type` attribute, allowing you to use any `serde`-compatible Rust types in our IDL. ``` table ViewportLayout ( "attr.rust.derive": "PartialEq", "attr.rust.override_crate": "re_viewport" ) { space_view_keys: [ubyte] (order: 100, "attr.rust.serde_type": "std::collections::BTreeSet<re_viewer_context::SpaceViewId>"); tree: [ubyte] (order: 101, "attr.rust.serde_type": "egui_tiles::Tree<re_viewer_context::SpaceViewId>"); auto_layout: bool (order: 102); } ``` This unblocks further blueprint experimentations, and is the last blocker to sunset `arrow2-convert`. - `SpaceViewComponent`, `SpaceViewMaximized` & `ViewportLayout` are now all implemented that way. - `re_viewport` is now free of `arrow2-convert`. --- `arrow2-convert` migration PR series: - #3853 - #3855 - #3897 - #3902 - #3917
teh-cmc
added a commit
that referenced
this pull request
Oct 19, 2023
The end of our wonderful journey. - `NumInstances` control column now has an actual dedicated component type. - `EntityPath` is now a component. - `Into<Cow<Self>>` impls have been cleaned up to generate way less code. - `arrow2_convert` is fully gone. --- `arrow2-convert` migration PR series: - #3853 - #3855 - #3897 - #3902 - #3917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
ObjectKind::Blueprintinto our codegen framework.Blueprintobjects are as expressive asDatatypeobjects (i.e. they don't have the artificial limitations that we impose onComponentobjects), but still implement theComponenttrait.Blueprint objects live in a separate module so as not to pollute LSP/docs/etc.
This allows us to replace existing
arrow2_convert-based blueprint types with fbs definitions instead.This PR does not cover
SerdeFieldshenanigans, that comes next.arrow2-convertmigration PR series:arrow2-convertmigration 1:TUID,RowId,TableId#3853arrow2-convertmigration 2: non-serde blueprint types #3855re_arrow2toarrow#3741What
Checklist