arrow2-convert migration 5: sunset arrow2-convert
#3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🏹 arrow
teh-cmc
force-pushed
the
cmc/arrow2convert_be_gone_4
branch
from
0b54344 to
ad9c851
Compare
4 tasks
teh-cmc
force-pushed
the
cmc/arrow2convert_be_gone_5
branch
from
68e707b to
3d6bae9
Compare
teh-cmc
commented
Oct 18, 2023
teh-cmc
commented
Oct 18, 2023
emilk
reviewed
Oct 18, 2023
| @@ -574,7 +574,7 @@ fn quote_arrow_field_serializer( | |||
| }) | |||
| .transpose() | |||
| }) | |||
| .collect::<::re_types_core::SerializationResult<Vec<_>>>()? | |||
There was a problem hiding this comment.
a ; after a collect that has no let binding? what is going on here?
There was a problem hiding this comment.
Yeah the whole "who's responsible for the trailing ';'" is a mess in general.
I'll clean that up during the switch to arrow1, likely by introducing a new rule that if your quote block does not do the assignment, then it should not include the trailing comma.
4 tasks
teh-cmc
added a commit
that referenced
this pull request
Oct 19, 2023
…3902) This introduces the `rust.attr.serde_type` attribute, allowing you to use any `serde`-compatible Rust types in our IDL. ``` table ViewportLayout ( "attr.rust.derive": "PartialEq", "attr.rust.override_crate": "re_viewport" ) { space_view_keys: [ubyte] (order: 100, "attr.rust.serde_type": "std::collections::BTreeSet<re_viewer_context::SpaceViewId>"); tree: [ubyte] (order: 101, "attr.rust.serde_type": "egui_tiles::Tree<re_viewer_context::SpaceViewId>"); auto_layout: bool (order: 102); } ``` This unblocks further blueprint experimentations, and is the last blocker to sunset `arrow2-convert`. - `SpaceViewComponent`, `SpaceViewMaximized` & `ViewportLayout` are now all implemented that way. - `re_viewport` is now free of `arrow2-convert`. --- `arrow2-convert` migration PR series: - #3853 - #3855 - #3897 - #3902 - #3917
teh-cmc
force-pushed
the
cmc/arrow2convert_be_gone_5
branch
from
3d6bae9 to
d139fa5
Compare
teh-cmc
added
the
exclude from changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end of our wonderful journey.
NumInstancescontrol column now has an actual dedicated component type.EntityPathis now a component.Into<Cow<Self>>impls have been cleaned up to generate way less code.arrow2_convertis fully gone.arrow2-convertmigration PR series:arrow2-convertmigration 1:TUID,RowId,TableId#3853arrow2-convertmigration 2: non-serde blueprint types #3855arrow2-convertmigration 3:attr.rust.override_crate& optimizing out dependencies #3897arrow2-convertmigration 4: support serde-based types in codegen #3902arrow2-convertmigration 5: sunsetarrow2-convert#3917arrow2-convertmigration 4: support serde-based types in codegen #3902 firstChecklist