python: don't generate empty __all__ thingies

rerun-io · Oct 13, 2023 · 6cc01d7 · 6cc01d7
1 parent e6f8dea
commit 6cc01d7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/crates/re_types_builder/src/codegen/python.rs b/crates/re_types_builder/src/codegen/python.rs
@@ -411,15 +411,17 @@ impl PythonCodeGenerator {
                 code.push_text(&clause, 1, 0);
             }
 
-            code.push_unindented_text(
-                format!(
-                    "
+            if !manifest.is_empty() {
+                code.push_unindented_text(
+                    format!(
+                        "
                 __all__ = [{manifest}]
 
                 ",
-                ),
-                0,
-            );
+                    ),
+                    0,
+                );
+            }
 
             let obj_code = if obj.is_struct() {
                 code_for_struct(reporter, arrow_registry, &ext_class, objects, obj)
@@ -508,7 +510,9 @@ fn write_init_file(
         let names = names.join(", ");
         code.push_text(&format!("from .{module} import {names}"), 1, 0);
     }
-    code.push_unindented_text(format!("\n__all__ = [{manifest}]"), 0);
+    if !manifest.is_empty() {
+        code.push_unindented_text(format!("\n__all__ = [{manifest}]"), 0);
+    }
     files_to_write.insert(path, code);
 }
 

diff --git a/rerun_py/tests/test_types/blueprint/__init__.py b/rerun_py/tests/test_types/blueprint/__init__.py