Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build yocto: cleanup #41

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

quaresmajose
Copy link
Contributor

No description provided.

.github/workflows/build-yocto.yml Outdated Show resolved Hide resolved
.github/workflows/build-yocto.yml Outdated Show resolved Hide resolved
@quaresmajose quaresmajose marked this pull request as ready for review October 15, 2024 16:18
@quaresmajose quaresmajose force-pushed the build-yocto-cleanup branch 3 times, most recently from 5e45439 to f3f43b4 Compare October 16, 2024 12:26
export PERSISTENT_DIR=/srv/gh-runners/quic-yocto
export DL_DIR=${PERSISTENT_DIR}/downloads
export SSTATE_DIR=${PERSISTENT_DIR}/sstate-cache
export KAS_BUILD_DIR=$(realpath $PWD/..)/build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is actually better to set KAS_WORK_DIR instead (KAS_BUILD_DIR is ${KAS_WORK_DIR}/build), that way it also clones the other repos outside the folder where kas build gets called (which is this repo).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I moved it to the outside of the repo ../kas, one dir node above.

@quaresmajose
Copy link
Contributor Author

Also changed from PERSISTENT_DIR to CACHE_DIR because the first is already part of bitbake.

@quaresmajose quaresmajose force-pushed the build-yocto-cleanup branch 2 times, most recently from 9d29f2d to afb7d39 Compare October 17, 2024 16:54
This variable will point to the persistent cache storage.

Signed-off-by: Jose Quaresma <[email protected]>
Set the KAS_WORK_DIR to a folder outside the repo.
Remove the build dir as it will be created by the oe-init-build-env script
and also the DL_DIR and SSTATE_DIR will be crated by bitbake if needed.

Signed-off-by: Jose Quaresma <[email protected]>
Copy link
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 778db0f into qualcomm-linux:main Oct 20, 2024
7 checks passed
@quaresmajose quaresmajose deleted the build-yocto-cleanup branch October 25, 2024 08:52
@quaresmajose quaresmajose mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants